aem-core-forms-components
aem-core-forms-components copied to clipboard
adobe
Password comp
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
Checklist:
- [ ] I have signed the Adobe Open Source CLA.
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [ ] I have read the CONTRIBUTING document.
- [ ] I have added tests to cover my changes and the overall coverage did not decrease.
- [ ] All unit tests pass on CircleCi.
- [ ] I ran all tests locally and they pass.
Lighthouse scores (mobile)
| Performance | Accessibility | Best-Practices | SEO | |
|---|---|---|---|---|
| Scores | 92 | 96 | 96 | 75 |
Lighthouse scores (desktop)
| Performance | Accessibility | Best-Practices | SEO | |
|---|---|---|---|---|
| Scores | 100 | 96 | 96 | 75 |
Accessibility Violations Found
| Id | Impact |
|---|---|
| label-title-only | serious |
| target-size | serious |
Accessibility Violations Found
| Id | Impact |
|---|---|
| label-title-only | serious |
| target-size | serious |
Accessibility Violations Found
| Id | Impact |
|---|---|
| label-title-only | serious |
| target-size | serious |
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 82.50%. Comparing base (
93cf3b0) to head (4747ab8).
Additional details and impacted files
@@ Coverage Diff @@
## dev #1316 +/- ##
============================================
+ Coverage 82.38% 82.50% +0.12%
- Complexity 946 959 +13
============================================
Files 105 106 +1
Lines 2430 2447 +17
Branches 332 334 +2
============================================
+ Hits 2002 2019 +17
Misses 260 260
Partials 168 168
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
Accessibility Violations Found
| Id | Impact |
|---|---|
| focus-order-semantics | minor |
| label-title-only | serious |
| landmark-one-main | moderate |
| region | moderate |
| target-size | serious |
Lighthouse scores (mobile)
| Performance | Accessibility | Best-Practices | SEO | |
|---|---|---|---|---|
| Scores | 91 | 96 | 96 | 75 |
Lighthouse scores (desktop)
| Performance | Accessibility | Best-Practices | SEO | |
|---|---|---|---|---|
| Scores | 100 | 96 | 96 | 75 |
Accessibility Violations Found
| Id | Impact |
|---|---|
| label-title-only | serious |
| target-size | serious |
Accessibility Violations Found
| Id | Impact |
|---|---|
| label-title-only | serious |
| target-size | serious |
Accessibility Violations Found
| Id | Impact |
|---|---|
| label-title-only | serious |
| target-size | serious |
Can we use the new field type in this PR ? Please sync with talmiz on this
Yes we have used new field type in this PR, please refer to this commit https://git.corp.adobe.com/livecycle/af2-docs/pull/211/files#diff-a2a39757552dd1988f477b116329eba154e51bff6f2530d575b16fe6c76cd833R192
For opening and closing eye icon, we have changed code in theme https://github.com/adobe/aem-forms-theme-canvas/pull/45/commits/17c7b854a6c8979be062919477e93fe3ceb53037
Accessibility Violations Found
| Id | Impact |
|---|---|
| focus-order-semantics | minor |
| label-title-only | serious |
| landmark-one-main | moderate |
| region | moderate |
| target-size | serious |
Accessibility Violations Found
| Id | Impact |
|---|---|
| label-title-only | serious |
| page-has-heading-one | moderate |
| target-size | serious |
Accessibility Violations Found
| Id | Impact |
|---|---|
| label-title-only | serious |
| page-has-heading-one | moderate |
| target-size | serious |
Lighthouse scores (mobile)
| Performance | Accessibility | Best-Practices | SEO | |
|---|---|---|---|---|
| Scores | 94 | 96 | 96 | 75 |
Lighthouse scores (desktop)
| Performance | Accessibility | Best-Practices | SEO | |
|---|---|---|---|---|
| Scores | 100 | 96 | 96 | 75 |
Accessibility Violations Found
| Id | Impact |
|---|---|
| label-title-only | serious |
| page-has-heading-one | moderate |
| target-size | serious |
Accessibility Violations Found
| Id | Impact |
|---|---|
| focus-order-semantics | minor |
| label-title-only | serious |
| landmark-one-main | moderate |
| region | moderate |
| target-size | serious |
Lighthouse scores (mobile)
| Performance | Accessibility | Best-Practices | SEO | |
|---|---|---|---|---|
| Scores | 94 | 96 | 96 | 75 |
Lighthouse scores (desktop)
| Performance | Accessibility | Best-Practices | SEO | |
|---|---|---|---|---|
| Scores | 100 | 96 | 96 | 75 |
Accessibility Violations Found
| Id | Impact |
|---|---|
| label-title-only | serious |
| target-size | serious |
Accessibility Violations Found
| Id | Impact |
|---|---|
| label-title-only | serious |
| target-size | serious |
Accessibility Violations Found
| Id | Impact |
|---|---|
| label-title-only | serious |
| page-has-heading-one | moderate |
| target-size | serious |
Accessibility Violations Found
| Id | Impact |
|---|---|
| focus-order-semantics | minor |
| label-title-only | serious |
| landmark-one-main | moderate |
| region | moderate |
| target-size | serious |
Lighthouse scores (mobile)
| Performance | Accessibility | Best-Practices | SEO | |
|---|---|---|---|---|
| Scores | 91 | 96 | 96 | 75 |
Lighthouse scores (desktop)
| Performance | Accessibility | Best-Practices | SEO | |
|---|---|---|---|---|
| Scores | 100 | 96 | 96 | 75 |
Accessibility Violations Found
| Id | Impact |
|---|---|
| label-title-only | serious |
| target-size | serious |