aem-core-cif-components icon indicating copy to clipboard operation
aem-core-cif-components copied to clipboard

Add missing Experience Platform Connector events to Core Components

Open laurentiumagureanu opened this issue 3 years ago • 1 comments

Description

Add necessary context and data for add to cart storefront event

Related Issue

CIF-2898

Motivation and Context

enables Beacon tracking

How Has This Been Tested?

Unit test

Screenshots (if appropriate):

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [x] I have signed the Adobe Open Source CLA.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document.
  • [x] I have added tests to cover my changes and the overall coverage did not decrease.
  • [x] All unit tests pass on CircleCi.
  • [x] I ran all tests locally and they pass.

laurentiumagureanu avatar Aug 17 '22 11:08 laurentiumagureanu

Codecov Report

Merging #949 (181aadb) into master (2dd2b2c) will increase coverage by 0.02%. The diff coverage is 96.50%.

@@             Coverage Diff              @@
##             master     #949      +/-   ##
============================================
+ Coverage     89.46%   89.49%   +0.02%     
- Complexity     2204     2211       +7     
============================================
  Files           351      354       +3     
  Lines          9857     9967     +110     
  Branches       1422     1436      +14     
============================================
+ Hits           8819     8920     +101     
- Misses          742      750       +8     
- Partials        296      297       +1     
Flag Coverage Δ
integration 52.22% <43.75%> (+0.04%) :arrow_up:
jest 86.68% <100.00%> (+0.13%) :arrow_up:
karma 95.53% <100.00%> (+0.20%) :arrow_up:
unittests 88.00% <81.25%> (-0.14%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ommerce/core/components/datalayer/ProductData.java 0.00% <0.00%> (ø)
...internal/models/v1/common/ProductListItemImpl.java 95.09% <0.00%> (-0.95%) :arrow_down:
...erce/core/components/models/product/GroupItem.java 0.00% <0.00%> (ø)
...ts/storefrontcontext/ProductStorefrontContext.java 0.00% <0.00%> (ø)
...torefrontcontext/ProductStorefrontContextImpl.java 90.00% <75.00%> (-10.00%) :arrow_down:
...ponents/internal/datalayer/DataLayerComponent.java 80.95% <100.00%> (+0.46%) :arrow_up:
...components/internal/datalayer/ProductDataImpl.java 100.00% <100.00%> (ø)
...ents/internal/models/v1/product/GroupItemImpl.java 100.00% <100.00%> (ø)
...onents/internal/models/v1/product/ProductImpl.java 87.55% <100.00%> (+0.05%) :arrow_up:
...nal/models/v1/productteaser/ProductTeaserImpl.java 90.66% <100.00%> (+0.12%) :arrow_up:
... and 18 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Aug 17 '22 13:08 codecov[bot]