aem-core-cif-components icon indicating copy to clipboard operation
aem-core-cif-components copied to clipboard

Code smells in CIF code

Open pithayx opened this issue 3 years ago • 2 comments

Expected Behavior - No Code Smells in AEMaaCS code scan.

Actual Behavior - Getting following code smell in the scan report -

cif-components-library:core-cif-components-all:2.0.0: Inclusion of both /etc/packages/adobe/aem650/core-cif-components-apps-2.0.0.zip/jcr:content and /apps/core in the same package violates the separation of immutable and mutable paths in the same package. : ImmutableMutableMixedPackage : https://www.adobe.com/go/aem_cmcq_immutablemutablemixe_en

Reproduce Scenario (including but not limited to)

Steps to Reproduce

Platform and Version: AEMaaCS 2022.7.8085.20220725T140323Z, CIF version :2.0.0

Sample Code that illustrates the problem

Logs taken while reproducing problem

pithayx avatar Aug 05 '22 06:08 pithayx

Hey @pithayx, can you please add steps to reproduce this issue?

Did you try to add the CIF sources to your cloud manager project? If so this is usually not the recommended approach. We provide binary distribution packages of CIF that you can embed as dependencies into your project.

buuhuu avatar Oct 11 '22 07:10 buuhuu

@Buuhuu We have embeded the package as dependency in our project. This error is reported when the code is deployed as a part of AEMaaCS Cloud Manager pipelines in the code scan report.

pithayx avatar Oct 12 '22 17:10 pithayx