aem-core-cif-components
aem-core-cif-components copied to clipboard
SITES-22965: Add function to set category filter type
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
Checklist:
- [ ] I have signed the Adobe Open Source CLA.
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [ ] I have read the CONTRIBUTING document.
- [ ] I have added tests to cover my changes and the overall coverage did not decrease.
- [ ] All unit tests pass on CircleCi.
- [ ] I ran all tests locally and they pass.
Codecov Report
Attention: Patch coverage is 96.10390% with 3 lines in your changes missing coverage. Please review.
Project coverage is 89.14%. Comparing base (
2ea43ba) to head (7eac3d3).
Additional details and impacted files
@@ Coverage Diff @@
## master #1011 +/- ##
============================================
+ Coverage 89.11% 89.14% +0.02%
- Complexity 2226 2247 +21
============================================
Files 355 355
Lines 10042 10097 +55
Branches 1447 1461 +14
============================================
+ Hits 8949 9001 +52
Misses 790 790
- Partials 303 306 +3
| Flag | Coverage Δ | |
|---|---|---|
| integration | 51.63% <48.05%> (-0.20%) |
:arrow_down: |
| jest | 86.68% <ø> (ø) |
|
| karma | 95.54% <ø> (ø) |
|
| unittests | 87.44% <96.10%> (+0.06%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@alwinjoseph02 , could you please update the readme of components where you added the new JCR property (categoryIdType) like here https://github.com/adobe/aem-core-cif-components/tree/master/ui.apps/src/main/content/jcr_root/apps/core/cif/components/commerce/featuredcategorylist/v1/featuredcategorylist#edit-dialog-properties
@alwinjoseph02 , LGTM! Thank you.