chore: trying section loader (DO NOT MERGE)
Test URLs:
- Before: https://main--aem-boilerplate--adobe.hlx.live/
- After: https://section-loader--aem-boilerplate--adobe.hlx.live/
this is just a test, do not merge.
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.
- [ ] Re-run PSI checks
- [ ] Re-sync branch
| Page | Scores | Audits | |
|---|---|---|---|
| / |
this removes complexity and makes LCP guessing more flexible.
| Page | Scores | Audits | |
|---|---|---|---|
| / |
I'm just seeing this. I think this PR is great. This is much closer to what we did on Milo.
https://github.com/da-sites/nexter/blob/main/nx/scripts/nexter.js#L125-L136
One thing we also did in Milo is that we do not allow a block to "pollute up" their class names into sections. We saw a lot of CSS written in Express due to competing section styles because of block names being attached on sections.
Our guiding principles on this topic:
- A block should never change the behavior of a section.
- A section should never impact the internals of a block.
Working on the aem-lib version of this PR.
I have created the PR in aem-lib to match all the changes required in aem.js: https://github.com/adobe/aem-lib/pull/80
I have aligned the aem.js of this PR with the build result of the aem-lib PR for testing purposes. Once the aem-lib PR is merged, this one can be merged without the aem.js changes.
Replaces https://github.com/adobe/aem-boilerplate/pull/382.