aem-boilerplate icon indicating copy to clipboard operation
aem-boilerplate copied to clipboard

chore: trying section loader (DO NOT MERGE)

Open davidnuescheler opened this issue 2 years ago • 7 comments

Test URLs:

  • Before: https://main--aem-boilerplate--adobe.hlx.live/
  • After: https://section-loader--aem-boilerplate--adobe.hlx.live/

this is just a test, do not merge.

davidnuescheler avatar Dec 09 '23 20:12 davidnuescheler

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

  • [ ] Re-run PSI checks
  • [ ] Re-sync branch
Commits

aem-code-sync[bot] avatar Dec 09 '23 20:12 aem-code-sync[bot]

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

aem-code-sync[bot] avatar Dec 09 '23 20:12 aem-code-sync[bot]

this removes complexity and makes LCP guessing more flexible.

davidnuescheler avatar Dec 09 '23 20:12 davidnuescheler

image

davidnuescheler avatar Dec 10 '23 15:12 davidnuescheler

image

davidnuescheler avatar Dec 10 '23 15:12 davidnuescheler

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

aem-code-sync[bot] avatar Dec 14 '23 21:12 aem-code-sync[bot]

I'm just seeing this. I think this PR is great. This is much closer to what we did on Milo.

https://github.com/da-sites/nexter/blob/main/nx/scripts/nexter.js#L125-L136

One thing we also did in Milo is that we do not allow a block to "pollute up" their class names into sections. We saw a lot of CSS written in Express due to competing section styles because of block names being attached on sections.

Screenshot 2024-03-16 at 1 23 32 PM

Our guiding principles on this topic:

  1. A block should never change the behavior of a section.
  2. A section should never impact the internals of a block.

auniverseaway avatar Mar 16 '24 19:03 auniverseaway

Working on the aem-lib version of this PR.

kptdobe avatar Jul 10 '24 12:07 kptdobe

I have created the PR in aem-lib to match all the changes required in aem.js: https://github.com/adobe/aem-lib/pull/80

I have aligned the aem.js of this PR with the build result of the aem-lib PR for testing purposes. Once the aem-lib PR is merged, this one can be merged without the aem.js changes.

kptdobe avatar Jul 11 '24 09:07 kptdobe

Replaces https://github.com/adobe/aem-boilerplate/pull/382.

kptdobe avatar Jul 16 '24 12:07 kptdobe