webhook icon indicating copy to clipboard operation
webhook copied to clipboard

Published 20 hours ago • verified publisher icon adnanh

Add ability to stream command output as a response

Open milolav opened this issue 5 years ago • 4 comments

Similar to the #251, with only one option for streaming and based on the current version of webhook (2.7.0)

Has a mysterious issue where response gets delayed for a few seconds when opening in a browser but starts immediately when opening with curl/wget.

Reference implementation https://play.golang.org/p/PpbPyXbtEs doesn't have this issue. Does anyone have an idea why is that happening?

milolav avatar Jul 25 '20 15:07 milolav

@milolav, please edit this PR to be against the development branch, not master. Also, the Travis CI builds are failed due to a bug in our Travis config. We should get fixed in development soon with #445, and then you can rebase.

moorereason avatar Jul 27 '20 22:07 moorereason

@moorereason I missed the argument in the test script. Fixed that and switched PR to be against the development branch

milolav avatar Jul 29 '20 00:07 milolav

@milolav, I still haven't taken a good look at this PR, but you should be able to rebase against development to fix the Travis CI builds.

moorereason avatar Jul 31 '20 17:07 moorereason

@moorereason rebased my master branch against the current development branch and merged the change for this PR.

milolav avatar Aug 05 '20 17:08 milolav