Aditya Toshniwal

Results 122 comments of Aditya Toshniwal
trafficstars

Tested with docker release candidate. Works fine.

> @adityatoshniwal was able to try it today. The solution provided does not resolve the issue at hand, config_local.py does not appear to be read during the entrypoint. As such...

I have raised this to the CodeMirror team here - https://discuss.codemirror.net/t/code-folding-for-postgresql-doesnt-work-as-expected/7993

When fixing this, please check - https://www.postgresql.org/message-id/CANQ9y02oCjQSd6SJXTcgi7m0F9jR6MUXQYT-Lu8wEibqp%2B-QWA%40mail.gmail.com

Impacted areas: 1. Query tool data grid. 2. Server mode File Manager. 3. Search Objects. 4. Schema Diff results grid.

Hi @dpage, How do you think we can handle this case?

@stephannn I checked our build process and it is already signing the installers as per the blog. You can check here https://github.com/pgadmin-org/pgadmin4/blob/master/Make.bat#L379

> When I see it correctly the https://github.com/pgadmin-org/pgadmin4/blob/master/pkg/win32/installer.iss.in file is used for the setup creating process. On the other hand, https://github.com/pgadmin-org/pgadmin4/blob/master/Make.bat#L379 is just signing the final setup file. What maybe...

> Hi, I rebuild the compiling process and it really makes a difference between signing during the compilation with inno setup and signing afterwards. Great! You can send the PR...

> [@adityatoshniwal](https://github.com/adityatoshniwal) , can you please try following command line: `"C:\Program Files (x86)\Inno Setup 6\ISCC.exe" "C:\tmp\installer.iss" "/Ssigntool=C:\tmp\signtool.exe sign /f C:\tmp\mycert2.pfx /tr http://timestamp.sectigo.com /td sha256 /fd sha256 /a /p 123456 $f"`...