monorepo-diff-buildkite-plugin icon indicating copy to clipboard operation
monorepo-diff-buildkite-plugin copied to clipboard

Published 20 hours ago • verified publisher icon adikari

Fatal on upload pipeline failure

Open stevenmatthewt opened this issue 3 years ago • 1 comments
trafficstars

Currently, if the resulting Buildkite pipeline fails to upload for any reason (e.g. it attempts to trigger a second pipeline that doesn't exist yet), the build just exits successfully. There's some logging, but this is generally missed since the build doesn't fail.

This PR updates the error check on uploadPipeline to use log.Fatalf, which will fail the step if the pipeline can't be uploaded successfully. I can't think of a scenario where it's desirable for this to succeed when the pipeline upload failed.

Resolves #67

stevenmatthewt avatar Jun 30 '22 14:06 stevenmatthewt

@chronotc any opportunity to look at this PR? I think it's a pretty simple enhancement.

stevenmatthewt avatar Aug 09 '22 16:08 stevenmatthewt

fixed by this https://github.com/chronotc/monorepo-diff-buildkite-plugin/pull/102

adikari avatar Nov 03 '22 06:11 adikari