Andras Deak

Results 109 comments of Andras Deak

Hmm. It should probably be more like a SortedDict (which is not to say that I know of an implementation of such). We want users to be able to insert...

> That is MultiBlock meshes are list like. That would also solve some vague qualms I've been forming with iteration behaviour.

> > It is recommended that one uses the iterators to iterate over composite datasets rather than using this API. > > For MultiBlock meshes, this seems like a suggestion...

> 1. A list-like primary implementation, e.g. multi[1] = mesh Works for me. What happens if someone assigns a missing index? > 2. When possible, add optional args for setting...

I know you probably just mean get/setitem here, but `multi.keys()` and `iter(multi)` behaviour will need thought too.

Thanks! Please also cross-check with #2863 for potential overlaps (I haven't looked at either yet).

> Regarding the tests I have a question: As this PR introduces different behaviour for different VTK versions, should there be separate tests for each version (and how would that...

I think the labeler task is about https://github.com/pyvista/pyvista/issues/2082, in any case the failure is due to a resource error. I'll just label your PR manually, hopefully the check will become...

Thank you for the report! I mostly understand what you see. What I don't understand is why the center is zero originally! I would argue that the issue is exactly...

> I don't know why this WARNING happens. Does anyone know why? > > ```shell > 2022-07-26T18:16:14.6714506Z /home/runner/work/pyvista/pyvista/doc/api/examples/_autosummary/pyvista.examples.planets.rst: WARNING: document isn't included in any toctree > ``` Sounds the same...