ember-progressive-webapp icon indicating copy to clipboard operation
ember-progressive-webapp copied to clipboard

Published 20 hours ago • verified publisher icon addyosmani

CriticalCSS

Open RobbieTheWagner opened this issue 9 years ago • 3 comments

Hi @addyosmani, I was wondering what your recommendations were for running criticalCSS with Ember were? I see you reference a file as your critical-css, but not sure the best way to generate it?

RobbieTheWagner avatar Aug 16 '16 02:08 RobbieTheWagner

@addyosmani do you have any recommendations for this? I would love to work on implementing critical for Ember, but probably need to do some magic stuff with the build to get it working.

RobbieTheWagner avatar Sep 29 '16 13:09 RobbieTheWagner

@rwwagner90 I'm also interested in using criticalCSS with Ember. It seems a bit daunting though!

I've been looking at this app and it doesn't appear to be generating critical css, rather it is just inlining the content of the whole apps css as show here

ianpetzer avatar Jan 04 '17 14:01 ianpetzer

@ianpetzer yeah, we would need to make some sort of ember addon to determine the critical CSS and inline it. Would be a lot of work. Inlining all CSS is not an option for large apps. Makes things very slow with a huge initial payload.

RobbieTheWagner avatar Jan 04 '17 14:01 RobbieTheWagner