docker-run-action icon indicating copy to clipboard operation
docker-run-action copied to clipboard

Yf make shell replacement optional

Open yfarjoun opened this issue 4 years ago • 5 comments

This PR enables the use of images with complex default ENTRYPOINT arrays.

In essence, it leaves the original entry point as it by default and simply puts a "sh -c

If the user would like to not use a shell or a prefix (for example because their entry point already has that) they can redefine each of them separately.

yfarjoun avatar Apr 05 '21 13:04 yfarjoun

I'm having trouble testing this because I can't echo ::set-output.... etc. as the CMD is only one string in this case.

I could repackage one of the docker images and provide it a more complex ENTRYPOINT, but I'm not sure how to do this.., any suggestions regarding the test @addnab ?

yfarjoun avatar Apr 05 '21 15:04 yfarjoun

Any ideas on how to test, or just take it as is? @addnab

yfarjoun avatar Apr 07 '21 18:04 yfarjoun

Hi @yfarjoun I'll take a look on Friday if it's ok. I'll work on adding a test for this as well.

addnab avatar Apr 07 '21 18:04 addnab

perfect! thanks. I just didn't want this to fall off your radar. I'm currently using a branch on my fork and I always prefer to move back to the "source" 😄

yfarjoun avatar Apr 07 '21 18:04 yfarjoun

I think that I don't like the design of this change...I'mm working on a different one.

yfarjoun avatar Apr 13 '21 17:04 yfarjoun