react-data-grid icon indicating copy to clipboard operation
react-data-grid copied to clipboard

TreeDataGridProps has wrong type for columns

Open tom-weiss opened this issue 1 year ago • 2 comments

TreeDataGridProps has wrong type for columns

Is currently set to: readonly Column<R, SR>[];

Should be readonly ColumnOrColumnGroup<R, SR>[];

To Reproduce

  1. Instantiate a TreeDataGrid with grouped columns

I am happy to create a PR with a fix if you want.

tom-weiss avatar Dec 12 '23 12:12 tom-weiss

TreeDataGrid does not support column groups at the moment and the types are correct.

amanmahajan7 avatar Jan 02 '24 18:01 amanmahajan7

And FYI, this change was made here https://github.com/adazzle/react-data-grid/pull/3287/files where row grouping was removed from the core Grid and moved into TreeGrid was titied up.

I ended up having to review the diff of releases to identify and fix all the breaking changes when I upgraded from 7.0.0-beta.34 to 7.0.0-beta.41.

paustint avatar Jan 03 '24 02:01 paustint