Columnizer-jQuery-Plugin icon indicating copy to clipboard operation
Columnizer-jQuery-Plugin copied to clipboard

Regression - last column is smaller.

Open danyaPostfactum opened this issue 11 years ago • 4 comments

This is how current version (1.6) works (in IE8-9): regression

This is an older version of columnizer: regression-before

Call:

$('.citylist').columnize({ width: 180 });

Unfortunately, I don't know a number of old version (I have minimized version only) It lacks manualBreaks, cssClassPrefix options, appendSafe function etc.

If you don't have no idea about the bug reason, I'll try to find a breaking commit.

danyaPostfactum avatar Dec 23 '13 17:12 danyaPostfactum

If you could track down the commit, that'd help me quite a lot. Also, could you send me the minimized version of colonizer that you're using? I may be able to reverse engineer the version number from it, but knowing the commit would definitely be better. Thanks!

adamwulf avatar Dec 23 '13 23:12 adamwulf

Ok, I got it: f01e71645c2f6b42431f72bbd6c32dd5100a6afe

I found that this commit fixes some cases, but brokes another ones. It works bad with small portion of content, and it does not handle margins/line-heights properly. Just look: This is how new version (with the applied commit) works: new-columnizer

This is how old version (just before applying the commit): old-columnizer

This is the test html: https://gist.github.com/danyaPostfactum/8109088

By the way, I'm using line-height instead of margin in my project, because webkit works bad with margins (I can see "steps" of spitted margins)

I should note that I'm using IE10 switched to IE9 or IE8 mode. I did not test it in original IE9.

danyaPostfactum avatar Dec 24 '13 05:12 danyaPostfactum

Awesome, thanks for tracking that commit down. I'll try and find some time soon to debug what went wrong

On Mon, Dec 23, 2013 at 11:27 PM, danyaPostfactum [email protected]:

Ok, I got it: f01e716https://github.com/adamwulf/Columnizer-jQuery-Plugin/commit/f01e71645c2f6b42431f72bbd6c32dd5100a6afe

I found that this commit fixes some cases, but brokes another ones. It works bad with small portion of content, and it does not handle margins/line-heights properly. Just look: This is how new version (with the applied commit) works: [image: new-columnizer]https://f.cloud.github.com/assets/1527097/1804574/e8654f48-6c5a-11e3-98d3-3f3a6add7bae.png

This is how old version (just before applying the commit): [image: old-columnizer]https://f.cloud.github.com/assets/1527097/1804575/fe8f985a-6c5a-11e3-90d1-0a444d70dfe7.png

This is the test html: https://gist.github.com/danyaPostfactum/8109088

By the way, I'm using line-height instead of margin in my project, because webkit works bad with margins (I can see "steps" of spitted margins)

I should note that I'm using IE10 switched to IE9 or IE8 mode. I did not test it in original IE9.

— Reply to this email directly or view it on GitHubhttps://github.com/adamwulf/Columnizer-jQuery-Plugin/issues/140#issuecomment-31159240 .

adamwulf avatar Dec 28 '13 04:12 adamwulf

Thank you for great plugin!

danyaPostfactum avatar Dec 28 '13 04:12 danyaPostfactum