Adam Růžička

Results 130 comments of Adam Růžička

I took the liberty rebasing this, let's see how this goes.

This was merged as part of #768. Thank you @pafernanr !

Wouldn't it be better to fix it instead of removing it, if possible?

A fourth option would be to provide a calculated field with `select` and do the sorting outside of scoped search. ```ruby # role.rb ... scope :with_locked, -> { select("roles.*,(origin IS...

That sounds reasonable. The only change I'd make is that in `application_controller.rb`, I'd turn the condition to `virt_column.blank? || model_of_controller.columns_hash[virt_column] || !base_scope.respond_to?("with_#{virt_column}")` so that it doesn't break in new ways...

Would it also make sense to have this on the job level?

@MariaAga could you please rebase so that the tests turn green?