Adam Retter

Results 573 comments of Adam Retter

> Can you point me to where the calls to javac and ajc happen? @line-o https://github.com/eXist-db/exist/blob/develop/exist-core/pom.xml#L980

> A jump to 17 makes sense to me; though you advocated in the past that we could not make these jumps due to limitations in (fill in any main...

> please remove the java8 compatibility thingy from the parent pom, see https://github.com/eXist-db/exist/pull/4564/files#diff-e6685ec8347a52581b8394c0744d4fce1b0db723b9574dab889ef2cece5c1f24L1155 @dizzzz I have posted a follow-up commit to address that.

@dizzzz @line-o @reinhapa I have now been able to remove the `8` from the ajc compile. This has the advantage that I have also been able to revert the `Buffer`...

At the moment this is not configurable, you would need to modify `SERVICE_NAME` and recompile eXist-db for yourself - https://github.com/eXist-db/exist/blob/develop/exist-core/src/main/java/org/exist/launcher/WindowsServiceManager.java#L56

@reinhapa A lot of your comments are duplicated from https://github.com/eXist-db/exist/pull/4574 as this PR is stacked atop that one as it is required.

@dizzzz Where are you seeing that error?

@reinhapa If you have a moment... I cannot understand why I am getting the javadoc error in the Javadoc CI run, as theproject has no dependency on `javax.servlet` any more...

> https://github.com/eXist-db/exist/actions/runs/3154141844/jobs/5131407589 > At least the Ubuntu build, error last lines @dizzzz I think that must be an old run, the current one is passing just fine.

@joewiz Are you sure you are using the correct PR? The PR disables the font-cache (https://github.com/wolfgangmm/tei-simple-pm/pull/23/commits/cfba8c3ac1b1d47a45fb46009a7adab7e0324bec#diff-27b7c450a06c704fad731b8ac920f159R40) However, your stacktrace shows the font-cache is still being used!