Adam Retter

Results 573 comments of Adam Retter

@luketebbs Excellent. All good arguments. It makes a lot of sense to me :-)

@luketebbs does this need to be rebased to address CI fixes?

@luketebbs I think it would be best to get CI passing in main (via a separate PR) before we then rebase this

@luketebbs Now we have merged the build fix PR would you mind rebasing this, and then I can take a look

Can you paste an example please?

At present all constraints are applied on a per-row basis, apart from 'unique' which can operate over multiple rows. Such a change is unfortunately not trivial. If we wish to...

@DavidUnderdown Okay looking forward to hearing more...

I have spent some time looking into this and I think we could do this through either a callback function to the output logger or through using some sort of...

@DavidUnderdown On the topic of performance there are a couple things that I started but did not have time to finish which could help: 1. Schema Parsing could be improved...

We use the Univocity CSV Parser internally. It does look like we could add a flag as you suggest which would instead use http://docs.univocity.com/parsers/2.7.3/index.html?com/univocity/parsers/common/input/BomInput.html