Adam Greig

> I originally did that because I didn't want to write a parser for separating the marker name from the address, especially because I didn't know would this even be...

Hi everyone! I missed this conversation at the time but coincidentally was working on something similar and would be interested in pushing this issue forward. I downloaded the official ST...

The stm32-rs crates have quite a simple structure I think: it's just one module per device, and each module is cfg-gated so when you build you only get your one...

I mostly use PACs directly rather than writing HALs, but in my experience almost all uses of `write` and `modify` look like `reg.modify(|_, w| w.field().variant());`, where it's very natural to...

Your idea in Version 1 of changing the variant methods to return a unit type so that existing code that doesn't return the write proxy still works without extra semicolons...

We discussed this in the meeting today (logs [here](https://freenode.logbot.info/rust-embedded/20201020#c5529448-c5529968)); generally I would say a number of people were concerned that the widespread code breakage is not justified by the improvement...

If anyone has any more feedback on this issue, please could you leave a comment in the next week? If there's no more updates by the next meeting (10th Nov),...

The logs from the most recent meeting are [here](https://freenode.logbot.info/rust-embedded/20201110#c5778096); the meetings are in the usual Embedded Rust Matrix chat/IRC channel (Tuesdays 8pm Berlin time) and open for anyone to join...

Thanks for the writeup! I think this is a good point and worth investigating, though I'm not sure how easy any wins will be. * In a lot of stm32-rs...

The commit @burrbull pointed out (https://github.com/rust-embedded/svd2rust/commit/189548a9b29ccfdc7890f613d48ac4471175e635) actually adds support for this to svd2rust (it will generate `clear_bit_by_one()` and `set_bit_by_zero()` methods where appropriate, as well as `toggle_bit()`), It also removes `set_bit()`...