adamantine icon indicating copy to clipboard operation
adamantine copied to clipboard

Updates for deal.II master past 9.5

Open masterleinad opened this issue 1 year ago • 3 comments

https://github.com/dealii/dealii/pull/16745 updated the SolverGMRES implementation and deal.II/lac/la_vector.h was removed in https://github.com/dealii/dealii/commit/d22e218017b8577437eb4fd36315dc6bf8653988.

masterleinad avatar Apr 30 '24 20:04 masterleinad

I've thought about this before and I don't want to support multiples versions of our dependencies. We do it at one place but retrospectively this was a mistake because we never check that path. Supporting multiples versions of our dependencies makes maintaining and testing the code more complicated and we gain nothing from it.

Rombur avatar May 01 '24 00:05 Rombur

The advantage I am seeing is that it is more difficult to add features to deal.II or work on implementation details for, say, the portable matrix-free, if the code doesn't support deal.II master. Also, the README, says

Installing adamantine requires:

  • MPI
  • A compiler that support C++17
  • CMake: 3.15 or later
  • Boost: 1.70.0 or later
  • ArborX: 1.4.1 or later
  • Trilinos: 14.4.0 or later
  • deal.II: 9.5 or later

masterleinad avatar May 01 '24 12:05 masterleinad

I am fine having this PR in the release branch because it's not a long-term burden but not in master. Unless there is a very good reason to support multiple versions, I do not want to do it.

work on implementation details for, say, the portable matrix-free

This is not a priority for this FY. There are other things more impactful that need to be done.

Rombur avatar May 03 '24 19:05 Rombur

Superseded by #359.

masterleinad avatar Jan 22 '25 22:01 masterleinad