Adam Li

Results 483 comments of Adam Li
trafficstars

> Regarding your first point the list of tuples of sets would probably work in the first instance. You could have an `included_edges` and `excluded_edges` list. It's not clear to...

We probably want both assumptions clearly indicated in docstrings and the Context. But documentation is a never-ending process, so that can be more of a long-haul when users have questions/etc.

Could the user just call an Encoder preprocessing function from scikit-learn? Or should we add that step for them? Either way good catch, we should document this accordingly for any...

I think we can follow a similar approach to scikit-learn and assume continuous by default and allow users to pass in a categorical mask (e.g. https://scikit-learn.org/stable/modules/generated/sklearn.ensemble.HistGradientBoostingClassifier.html). Idk if range of...

Design-wise, skim a look at networkx documentation/code and how it structures the graph classes vs functions. We are implementing a function here. The function should: - check for some validity...

> I am having difficulty understanding the validity part, can you elaborate on how one would check the validity of a PAG (for the purpose of this function, wouldn't simply...

> @adam2392 I just reviewed the PAG code and there is a function `is_valid_mec_graph` that appears to enforce the validity check in the `PAG` class. Is that understanding correct? I...

Is this implemented in #93, or is your proposal to add this in a separate PR?

@jaron-lee hey know you're prolly busy doing more interesting things at your internship :) Just wanted to check in to see if you think we should just do a release...

Yep! These are all valid `X ... -o ..., Y`, or `X ... o-o ..., Y`, or ``X ... o-> ..., Y`, or `X ... -- ..., Y`. So the...