DHT-sensor-library icon indicating copy to clipboard operation
DHT-sensor-library copied to clipboard

Duplicate definition of InterruptLock on ESP8266

Open dok-net opened this issue 6 years ago • 9 comments

The InterruptLock exists in cores/esp8266/interrupts.h in ESP8266 Arduino.

  • This PR adds a simple preprocessor guard to elicit the redefinition of InterruptLock for the ESP8266 target.

dok-net avatar Jun 24 '19 20:06 dok-net

hi travis is not passing @dok-net do you know why?

ladyada avatar Jul 18 '19 15:07 ladyada

It's not building against ESP8266 Arduino master branch, is it? The namespace fix for esp8266::InterruptLock is in https://github.com/esp8266/Arduino/commit/f5a882d03d30451ebcfa832293021748a372503a

Dependency hells all over the place.

dok-net avatar Jul 18 '19 21:07 dok-net

we test against release, that's what everyone's got :)

ladyada avatar Jul 18 '19 21:07 ladyada

Yeah, except, when I got my first ESP8266, the documentation strongly suggested to get the esp8266-community framework direct from git, and that usually gives you the master branch, more precisely, the HEAD of that. Now here we are...

dok-net avatar Jul 18 '19 21:07 dok-net

may be...but 99% of people using ESP8266 don't - they use the BSP manager built into arduino.

ladyada avatar Jul 18 '19 21:07 ladyada

Dependency hell... 2019... OMG... but never mind, I've reverted the premature alignment to master HEAD; mea culpa. Please remember/remind me/allow me to PR once time comes and ESP8266 Arduino releases next time. Thanks for all those invaluable hardware libraries! By the way, there's still some other PRs of mine pending heh heh

dok-net avatar Jul 18 '19 21:07 dok-net

as you can see, we have hundreds of libraries, and PRs are not trivial to merge. they take many hours to analyze and vet. you can help get PRs merged by testing/vetting other PR's!

ladyada avatar Jul 18 '19 21:07 ladyada

Good to know!

dok-net avatar Jul 18 '19 21:07 dok-net

2.6.0 is released, please retest.

devyte avatar Nov 09 '19 15:11 devyte