Adafruit_CircuitPython_MiniMQTT icon indicating copy to clipboard operation
Adafruit_CircuitPython_MiniMQTT copied to clipboard

remove the workaround for buggy recv_into()

Open vladak opened this issue 2 years ago • 3 comments

The \x00 literal should be removed https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT/blob/342b8c99b2c8f10b605cc8311bf5f394f4d18e92/adafruit_minimqtt/adafruit_minimqtt.py#L984 once https://github.com/adafruit/circuitpython/issues/7606 is fixed.

vladak avatar Feb 21 '23 07:02 vladak

This should probably wait for some time for the CP versions with the fix to percolate to the wide public. This could take a long time, I think.

vladak avatar Mar 07 '23 19:03 vladak

Both of these were added to CircuitPython as of 8.1.0 beta 1, let's keep this code in until 8.1.0 is stable and released.

brentru avatar Apr 11 '23 14:04 brentru

8.1.0 has been stable as of last week it seems.

vladak avatar May 31 '23 19:05 vladak