ada icon indicating copy to clipboard operation
ada copied to clipboard

Benchmarks doesn't run on Windows

Open anonrig opened this issue 1 year ago • 5 comments

We should make our benchmarks run on Windows to open room for optimizations.

cc @lemire

anonrig avatar May 07 '24 01:05 anonrig

They work for me, except for the part where the Rust integration breaks, but we can just disable it: https://github.com/ada-url/ada/pull/651

lemire avatar May 07 '24 04:05 lemire

@anonrig Does it work for you now that https://github.com/ada-url/ada/pull/651 is merged? If so, I recommend closing this issue. Or changing its title.

lemire avatar May 07 '24 13:05 lemire

@lemire Thanks. It seems it fixes the issue for me. Currently, cmake detects MSVC as the compiler to build and compile Ada for me on Windows. The question is how do you execute benchmarks on Windows? There is no .exe file?

anonrig avatar May 12 '24 23:05 anonrig

@anonrig There should be... it should be in build/benchmarks/Release/something.exe or build/benchmarks/Debug/something.exe depending on how you invoked cmake --build (e.g., cmake --build build --config Release or something like it.).

(Note that my instructions can be slightly wrong, I did not check.)

lemire avatar May 13 '24 00:05 lemire

There definitively should .exe files. It slightly different from mac/linux in that you need to specify release/debug and the release/debug files are in different locations.

lemire avatar May 13 '24 00:05 lemire