actix-extras icon indicating copy to clipboard operation
actix-extras copied to clipboard

feature(session): add deadpool-redis compatibility

Open 0rangeFox opened this issue 1 year ago • 1 comments
trafficstars

PR Type

Feature

PR Checklist

  • [x] Tests for the changes have been added / updated.
  • [x] Documentation comments have been added / updated.
  • [x] A changelog entry has been made for the appropriate packages.
  • [x] Format code with the nightly rustfmt (cargo +nightly fmt).

Overview

A new feature named redis-dp-session has been added, as well as the logic for accepting the deadpool-redis library in the redis-rs file, since deadpool-redis uses redis-rs in under the hood, so both are compatible and instead of duplicating, some attributes have been added to control the compilation of the features that are selected.

0rangeFox avatar Jan 08 '24 13:01 0rangeFox

The doc tests workflow is failing because there is an example code in redis_rs in the Deadpool Redis section, but ins't marked only for the feature redis-dp-session, is there any way to control this so that the workflow succeeds?

0rangeFox avatar Jan 22 '24 17:01 0rangeFox

This is actually blocked on a new release of deadpool-redis with a redis v0.26 dependency update.

robjtede avatar Aug 03 '24 08:08 robjtede

thanks for your work on this @0rangeFox 🎉

robjtede avatar Aug 06 '24 13:08 robjtede