activist icon indicating copy to clipboard operation
activist copied to clipboard

added orgs to populate db management command, improved org factory

Open to-sta opened this issue 1 year ago • 2 comments

Contributor checklist


Description

I have added the organizations to the populate db command.

WIP:

  • org_text needs to be added to the OrganizationFactory
  • Events should be added
  • Group should be added

Related issue

  • #938

to-sta avatar Aug 11 '24 14:08 to-sta

Thank you for the pull request!

The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • [x] The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local activist repo
  • [ ] The TypeScript and formatting workflows within the PR checks do not indicate new errors in the files changed

  • [x] The Playwright end to end and Zap penetration tests have been ran and are passing (if necessary)

  • [x] The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

github-actions[bot] avatar Aug 11 '24 14:08 github-actions[bot]

Deploy Preview for activist-org canceled.

Name Link
Latest commit bfe641445bcf5b8ca3e6ad330f5e76e41bf85c7e
Latest deploy log https://app.netlify.com/sites/activist-org/deploys/66dc9c0714dbfc0009781132

netlify[bot] avatar Aug 11 '24 14:08 netlify[bot]

I removed the StatusType query within the OrganizationFactory and switched to the factory_boy implementation. With that, we are removing the need of db access for fixtures.

to-sta avatar Aug 12 '24 21:08 to-sta

I've reduced the number of entities/users/events created to 10 as the frontend build speed is faster, and everything's running in parallel now, so the frontend was actually loading faster than the backend with 100 (and even 50).

andrewtavis avatar Sep 07 '24 13:09 andrewtavis

This still needs work to get the tests running, and the organization text table isn't returning a description – navigating to /organizations doesn't work as descriptions aren't coming through.

andrewtavis avatar Sep 07 '24 13:09 andrewtavis