activist icon indicating copy to clipboard operation
activist copied to clipboard

Add boolean transit layers option to events map

Open andrewtavis opened this issue 1 year ago • 21 comments

Terms

Description

Based on discussions in the most recent dev sync, one final element that should be added to the map for events is a menu option to control certain layers. We would like this to have three options:

  • One to toggle public transit maps

  • One to toggle biking routes

  • One that's a radio option for how the directions should be routes (walking, biking or driving)

    • This is related to #685
  • Note that this is blocked by #673 that is where we're learning as a community how to make a clickable map option that calls a function to clear the directions.

Contribution

Happy to work on this myself or support someone with interest when this is unblocked!

andrewtavis avatar Feb 24 '24 11:02 andrewtavis

As of now this issue would just focus on the bike route and transit map layers, and we could make another issue for switching the routing options once #685 is closed. I've just updated the Figma designs for this, which can further be seen below:

Mode=Light, Mobile=False, Type=Map, Disabled=False

Mode=Light, Mobile=False, Type=Map, Disabled=False (2)

In the second image above we have the biking option as being selected (not reflected in the map). The selected option would change color, as would the layers color to indicate that one layer has been added.

CC @nicholas-vecchio, in case you'd have interest :)

andrewtavis avatar Apr 07 '24 11:04 andrewtavis

First step would be researching a way to add in the layers for the transit maps or biking maps onto the map, but hopefully there are extensions/plugins for this from OSM or another provider 😊

andrewtavis avatar Apr 07 '24 11:04 andrewtavis

Thanks for the mention @andrewtavis I'd be happy to look into this :)

nicholas-vecchio avatar Apr 10 '24 02:04 nicholas-vecchio

Nice, @nicholas-vecchio! Really excited to hear what comes from this! Let me know if you need some support here, and happy to do a call to discuss at some point 😊

andrewtavis avatar Apr 10 '24 04:04 andrewtavis

Also wanted to mention that it'd be great to have you in the bi-weekly Saturday dev syncs, if you can make it ever :) Next one is Saturday the 20th of April at 15:00 UTC, with the link and further details being in the Development channel on Matrix.

andrewtavis avatar Apr 10 '24 05:04 andrewtavis

Note on this, @nicholas-vecchio, I've also just made #832 that's looking into the switch directions API/profile option, as we have been able to figure out how to do that at this point. Let me know if there's anything I can do here to support!

andrewtavis avatar Apr 22 '24 16:04 andrewtavis

Hey @nicholas-vecchio 👋 Quick check in to see how you're doing on this :) Let me know if you'd like to do a call at some point to check in on this! Would be happy to 😊

andrewtavis avatar May 18 '24 16:05 andrewtavis

Hello @andrewtavis apologies for taking so long to get back to you! I'll begin experimenting to see if I can get cycling layers to work via an open source cycling map, but frankly I'm very unsure where it would be possible to source public transport tiles from.

nicholas-vecchio avatar Jun 25 '24 04:06 nicholas-vecchio

No stress, @nicholas-vecchio! I've had lots to do myself :) Looking at the public transit options for a quick moment, at first glance maybe Transitland vector tiles or their REST API would work? I'd be happy to make an API key and send it along to you to play around with, which is how we did the captcha work with someone :)

Let's focus on the bike routes first though! Let me know if there's anything I can do to help 😊

andrewtavis avatar Jun 25 '24 06:06 andrewtavis

Hey @nicholas-vecchio 👋 We discussed this in the last dev sync :) What do you think about switching the context for this to being just for a boolean toggle for the bike routes? This would follow a lot of the work that @GrandSuccess87 did for the route profile switcher in #832, and would make use of the raster layers that OpenStreetMap has already :) We'd just switch the layer profile with something like the following:

https://b.tile-cyclosm.openstreetmap.fr/cyclosm/{z}/{x}/{y}.png

From there we'd expand to include the transit maps once @wkyoshida has checked out Transitland :)

Let us know how this sounds!

andrewtavis avatar Jul 24 '24 19:07 andrewtavis

With #949 merged in the only thing that we'd like from this at this point is for an option to show the public transit map, with this option being a boolean. FYI @nicholas-vecchio, @wkyoshida implemented the bike routes such that they're visible when the user is leveraging the bike directions option 🚲 @wkyoshida, what are your thoughts on the transit maps?

Will change the issue name to reflect the new scope :)

andrewtavis avatar Aug 30 '24 17:08 andrewtavis