activist icon indicating copy to clipboard operation
activist copied to clipboard

Add Signal to Modal Share Page Component

Open GrandSuccess87 opened this issue 1 year ago • 6 comments

Terms

Description

This issue will focus on adding support to share activist pages (event/organization/group) on Signal via the modal share page component.

This component lives in frontend/components/modal.

Icons would ideally come from one icon source on Icones such as CoreUI Brands.

You may also find the icons you need on Bootstrap.

Contribution

Happy to pair up with someone on this or tackle it myself :))

GrandSuccess87 avatar Feb 10 '24 17:02 GrandSuccess87

Note: Modal Share Page Component #581 is in progress

GrandSuccess87 avatar Feb 10 '24 17:02 GrandSuccess87

@andrewtavis @GrandSuccess87 I created the pull request to add the icon. But am not sure what URL we are linking to from it.

Mister-Tofu-tech avatar Apr 30 '24 05:04 Mister-Tofu-tech

Hey @Mister-Tofu-tech 👋 Thanks for sending along the PR. I'll make some comments as there are things that would need to change, and then maybe we can figure out what URL it should point to and you can implement that as well :)

andrewtavis avatar Apr 30 '24 10:04 andrewtavis

Hi, I would be happy to work on this. Thanks!

UnknownSean8 avatar Jun 15 '24 16:06 UnknownSean8

@UnknownSean8 will be helping a bit on the share part of this once I bring in @Mister-Tofu-tech's PR :) Thanks, @UnknownSean8!

andrewtavis avatar Jun 15 '24 16:06 andrewtavis

Ping @UnknownSean8 👋 With ea8f4fe and #855 being merged we're ready to work on the share functionality :) Thanks for the work here, @Mister-Tofu-tech!

andrewtavis avatar Jun 16 '24 14:06 andrewtavis

Closed via #955 🚀 Thanks for the all the efforts here, all, and especially for the great execution, @UnknownSean8! We're not able to directly open Signal with a message, but copying the URL and opening the app should work well 😊

andrewtavis avatar Aug 31 '24 13:08 andrewtavis