Add top shadow to sidebar footer when content expands below

[andrewtavis]

trafficstars

Terms

• [X] I have searched open and closed feature requests
• [X] I agree to follow activist's Code of Conduct

Description

This issue would add a check to the sidebar footer for when the content of the sidebar index or the sidebar filters is scrollable, and if that is the case then we'll want a slight top shadow to be added to the sidebar footer such that it appears over the content.

The shadow should be shadow-sm shadow-zinc-700, but we'll need to make sure it's only at the top :)

Contribution

Happy to support someone on this or get to it eventually myself! This is a great good first issue for new contributors, and those already in the community are also welcome to pick it up 😊

[lchauha]

Hi @andrewtavis I would like to work on this issue. Please assign this to me.

[andrewtavis]

Hey @lchauha 👋 Thanks for picking up two issues already! Will assign, and let me know if there's anything I can do to help 😊

[andrewtavis]

Hey @lchauha 👋 Checking in on this and #578 :) Let me know if there's anything I can do to help!

[arescrimson]

Hey, @lchauha ! Was just wondering if you needed any help on this, would be happy to try and test things out if you need an extra hand. As I saw that this is also related to issue #578, let me know if you need anything there as well :))

[andrewtavis]

Thanks for checking in, @arescrimson :) I'll go ahead and assign you here!

@lchauha, you'd be more then welcome to pick up another issue at another time. Please let me know if you'd like to 😊

[andrewtavis]

For this one we can be doing the "top shadow" within SidebarLeft, with the goal for this being that the shadow would only appear if the sidebar is scrollable :)

[andrewtavis]

Hey @arescrimson 👋 Checking in with you on this and the other issue :) We're still in the dev sync call if you'd like to join and discuss 😊

[arescrimson]

Hi, thanks for checking in @andrewtavis! I was actually planning to get this done this weekend, but because of some issues that's kept me busy this past week, I unfortunately had to miss the dev call. However, I'll keep you posted! After this weekend, I should have more time to tackle both of these issues 😁

[arescrimson]

Also great to see all the latest issues, problems and new contributors added within the last week! Really cool to see how this project is growing 😄

[andrewtavis]

We're still in the call if you want to say hi! But ya, let me know and happy to jump on a quick one to discuss 😊

[andrewtavis]

Hey @josueemartinezz 👋 I'm seeing there's a commit that references this. Do you want to send along a PR for this?

[andrewtavis]

#578 was just closed, but the issue here is that the padding around the footer makes it so that shadows are applied from the container of the footer rather than the menu option. To illustrate what I'm talking about:

There's a p-1 around the sidebar left footer, and then also pr-4 is applied in this case as the sidebar is expanded. I've tried to make the background that the padding creates transparent, but it doesn't work. Not really sure where to go from here, but it's not a high priority :)

Unassigning for now, @arescrimson, just in case someone else wants to give it a shot. Hope all's well with you!

[PustakP]

Hi @andrewtavis, I tried helping out with this issue, please have a look :)

[andrewtavis]

Hey @PustakP! I'll check out the PR! :) Thanks for working on this and the detailed PR commit 😊

[mstcyr2]

Hi @andrewtavis! I tried out a possible solution for this. I wasn't sure whether you wanted the background of the footer visible or not based on your previous comment, so right now it looks like this. I'm willing to continue working on it if you have other suggestions. Thanks!