activist icon indicating copy to clipboard operation
activist copied to clipboard

Expand ESLint with further rules

Open andrewtavis opened this issue 2 years ago • 7 comments
trafficstars

Terms

Description

This issue is to discuss and add new ESLint rules and also to refactor the codebase as needed to make it compliant after the changes :)

Contribution

@Robert-Kovalcuk had some ideas of some rules that we should add. Let's discuss and we can check in with some others and go from there!

andrewtavis avatar Nov 17 '23 23:11 andrewtavis

CC @to-sta :)

andrewtavis avatar Nov 17 '23 23:11 andrewtavis

Yes, I'll definitely have a look at that, out of the top of my mind I think, we should enforce multi-word components

Robert-Kovalcuk avatar Nov 18 '23 08:11 Robert-Kovalcuk

Thanks @Robert-Kovalcuk!

andrewtavis avatar Nov 18 '23 08:11 andrewtavis

@Robert-Kovalcuk good idea 💯.

to-sta avatar Nov 18 '23 10:11 to-sta

Checking for type any would be interesting. Maybe there is a rule for disallowing type any.

to-sta avatar Dec 08 '23 18:12 to-sta

CC @lucianmurmurache: this is the ESLint issue I was talking with you about. @Robert-Kovalcuk, @lucianmurmurache is adding things into the ESLint setup to expand a11y linting. Figured adding him into the discussion makes sense 😊

andrewtavis avatar Mar 15 '24 20:03 andrewtavis

Hey @Robert-Kovalcuk 👋 Checking in on this one as it definitely would be good to expand the rules again soon :) Let me know if you have time for a call soon!

andrewtavis avatar Apr 16 '24 22:04 andrewtavis