activist
activist copied to clipboard
markdown to WYSIWYG editor and vice versa
Contributor checklist
- [x] This pull request is on a separate branch and not the main branch
- [x] I have run the tests for the backend and frontend depending on what's needed for my changes as described in the testing section of the contributing guide
Description
This PR implements the markdown to WYSIWYG editor and vice versa, there is still some improvements to be made.
Related issue
- #1145
Deploy Preview for activist-org ready!
| Name | Link |
|---|---|
| Latest commit | dd3bdf6b9c4f267f5dd42f29fd3747008d93a722 |
| Latest deploy log | https://app.netlify.com/projects/activist-org/deploys/685855fb4db2f100081c25ab |
| Deploy Preview | https://deploy-preview-1235--activist-org.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify project configuration.
Thank you for the pull request! ❤️
The activist team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. Also consider attending our bi-weekly Saturday developer syncs! It'd be great to meet you 😊
Maintainer Checklist
The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
-
[x] The TypeScript, pytest and formatting workflows within the PR checks do not indicate new errors in the files changed
-
[x] The Playwright end to end and Zap penetration tests have been ran and are passing (if necessary)
-
[x] The changelog has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)
Via the discussion that we've had on our call, @UnknownSean8, what's needed here is:
- The height of the write mode for the markdown editor should be conditionally set based on the number of lines of the content when a user switches from preview mode back to write mode
- We need a checkbox under the text entry for switching on Markdown support rather than the
This editor supports Markdownmessage- The text should instead be
Enable Markdown support - Let's keep the markdown icon so that the option is easier for developers to recognize
- The text should instead be
Quick note as well that we should do an update of the i18n key for this and also delete all localizations as the text will need to change on Weblate. i18n.components.card_discussion_input.markdown_support should instead be i18n.components.card_discussion_input.enable_markdown. I can do this! 😊
Thanks for the amazing work here! 🚀
Hi, there are roadblocks here, might need some time to fix.
- Height of the texteditor is not resonsive when the button is pressed.
- Buttons for the WYSIWYG is not working.
All good, @UnknownSean8! Let me know if another call would help! 😊
The above fixes the merge conflicts, @UnknownSean8 :) Let me know if another call to finalize this would help! 😊
Heyo @UnknownSean8 👋 Quick checkin to see what you're thinking in terms of timing here :) No stress as it's not too pressing, but also nice to bring it in. Happy to hop on a call to pair code the last of it!
@andrewtavis, I have fixed the branch. Feel free to test it out, or we can schedule a short pairing session to check it out. Thanks!
Amazing work here, @UnknownSean8! Let me know when you're free to look into this :) I'll write to you on Matrix now 😊