activist
activist copied to clipboard
activist-org
Rework UI for first organization, group and event main image change
Terms
- [x] I have searched open and closed feature requests
- [x] I agree to follow activist's Code of Conduct
Description
As of now left sidebar images for organizations, groups and events have an icon and a model to change their image (as of now nonfunctional). It was decided yesterday that this behavior is confusing to the user. It would be best if this + button on the left sidebar icons that triggers the image model would instead be removed and replaced with an optional CTA button that appears below the left sidebar icon whenever there isn't an icon added by a user. When there is an icon added by a user then it would need to be removed in the settings once the work in #1200 is finished :)
Contribution
Happy to support with this, pick it up or review as needed!
Hi, if help is still needed for this issue, I would like to contribute to this issue.
Sure thing, @celine36! I'll assign you now :) Please let us know if you need any assistance! 😊
Hi @andrewtavis, I tried a couple of small changes on a button tag but could not see it when I used Docker. Do I have to git commit the changes when using Docker to see if they worked?
Hey @celine36 👋 The changes should be reflected and hot reloaded into the frontend when you have Docker up and running with docker compose --env-file .env.dev up --build :) Maybe try changing something basic like removing a component from a page and see if it's reflected on the page? Try reloading the page as hot reload could be malfunctioning 🤔 Please let me know if you're continuing to experience problems here and we'll support!
Hi @andrewtavis, thanks, it works now, I didn't make the change that I thought I did
Great to hear, @celine36! Please let us know if you need more support :)
Hi, @andrewtavis, I have made the layout changes to the button for the image upload for each event and each organisation in the left sidebar, to push them back to celine36/activist, do I use git commit and then git push?
Yes you can git commit and git push and then you should be able to open a pull request on the repository here 😊 Looking forward to the review!
Closed by #1248 :) Thanks for the contribution here, @celine36!
@mattburnett-repo, for now we have a CTA button under the images, which is always present as we're not loading the entities into the sidebar index to then check if the image is there (as you know).