Test coverage for social media links and image upload

[mattburnett-repo]

Terms

• [x] I have searched open and closed feature requests
• [x] I agree to follow activist's Code of Conduct

Description

The organization / social links + image upload frontend components need tests (vitest and Playwright).

Contribution

No response

[amleshwar-p]

I would like to work on this!

[andrewtavis]

Sounds good, @amleshwar-p! Let's maybe start with the vitest tests for these and then move on to playwright end to end tests after that 😊 Appreciate your interest in helping here!

[MelvinManni]

@andrewtavis can i pick this up?

[andrewtavis]

Forgot to write into this one :) Happy to work with you on this, @MelvinManni! Please let us know if you have any questions 😊 @amleshwar-p, please let us know if you've already made progress here, or maybe you can collaborate with @MelvinManni and then pick up another issue in the future 🚀

[saitejapcv]

Hi, can i work on this issue

[andrewtavis]

Adding @saitejapcv into the assignees 😊 Thanks for your offer to help, @saitejapcv! Please let us know if there's anything we can do to support :)

[willsaliba]

Which are the specific organization / social links + image upload frontend components which need tests?

[andrewtavis]

Thanks for checking in here, @willsaliba :) Let's start with say the social link ones. If you go to an organization page on activist you'll see this in the "Connect" card (CardConnect is the component). This is the component that allows organizations and groups to link to other pages of theirs. This same component is on group pages.

You can get to an organization page via the following after loading up the Docker containers as described in the environment setup guide:

• Click View organizations
• Select one of the listed organizations
• The Connect component is the last one on the About page that you're navigated to

You can get to a group page via:

• Selecting Groups in the sidebar of the organization About page above
• Selecting the group that the backend has populated for the organization
• The Connect component is in the same place on this page

Let us know if you have further questions or if you have ideas for the tests! 😊

[sailanka02]

@andrewtavis and @mattburnett-repo, I was wondering if this issue was closed. If not can I contribute to this?

[andrewtavis]

Sure thing, @sailanka02 :) Please let us know if you need any support here! :)

[touseefspace]

Hey @andrewtavis , hope everything's good. I would like to contribute in it, any scope?

[andrewtavis]

Hey @amleshwar-p 👋 Would be great to get some support here, but I think we might go a bit more towards Playwright end to end tests here now as is done in frontend/test-e2e. Would you have interest in that? We'll also need #1392 merged in before, but that will be done later today. Let us know, and happy to assign from there!

[amyanger]

@andrewtavis I can provide some support on this since it's been quiet if that's okay?

[andrewtavis]

Hey @amyanger 👋 If you'd like to work on some end to end tests for this, then that would be really nice :) I explained a bit about this in my comment above. Maybe you could look into social links and @amleshwar-p could look into image uploads?

[amyanger]

Hi @andrewtavis I will have a look, probably won't take me long to get both the tests done in the next few days to be honest. I will see what I get done and then you can take a look but I didn't wanna take away too much work from these other guys. This has just looked quiet for the past few days though.

[andrewtavis]

Makes sense, and is something that we can split up, @amyanger :) Appreciate you looking for so many ways to help!

[UnknownSean8]

Hi, I will work on this in the meantime. Let me know if there's anyone interested and happy to collaborate as well, or if @andrewtavis have other plans for this! 😄

[andrewtavis]

Thanks so much for picking this up, @UnknownSean8! Great to have your support on the e2e tests 😊 Let us know if you need some support with this!

[vickvey]

Hey Is this issue still active? Can i work on this??

[UnknownSean8]

Hi @vickvey, thank you for your interest in this issue! I am currently working on the playwright e2e tests, maybe you would be interested in writing the vitest for it? @andrewtavis wdy think about this?

[andrewtavis]

Would definitely be something that could be worked on! @nicki182 is planning on making tons of issues for unit tests for frontend components soon. Would you like us to make an initial issue in that series for you, @vickvey?

[nicki182]

Yeah, I think either tonight or tomorrow we can see about it