Switch sidebar menu logic to use layouts

[andrewtavis]

trafficstars

Terms

• [X] I have searched open and closed feature requests
• [X] I agree to follow activist's Code of Conduct

Description

In discussing some bugs for the platform, a decision was made that the current way that we're deriving the sidebar menus is brittle because it's being determined based on URL based checks. We should instead determine this based on the actual routes using layouts - i.e. all /organizations pages would have a layout with the given sidebar menu.

Contribution

Happy to look into this! 😊

[andrewtavis]

Note here that we need to further hoist other component logic into the layouts, not just the sidebar :)

[andrewtavis]

• For /organization/UUID routes we want to be making one call on the layout level that then instantiates all needed components for a given page based on the route and getting the id
• For /organizations/UUID/groups/UUID we would create a sub layout of the organizations layout to then bring in the organization through the parent layout
• For /events/UUID we would need to do two different calls via the event layout

[kirasvg]

Hi @andrewtavis ,I would like to work on this issue. Could you please assign it to me?

[andrewtavis]

Hi @kirasvg 👋 This is a pretty pressing issue and is likely something that I'll pick up in the coming days. If something changes or I'm able to break it down a bit better then I'll let you know! As it stands there are just so many changes that will need to happen.

Thanks for your interest, and please let us know if there's something else you'd have interest in working on in the meantime!

[Leon-Xie123]

Hi @andrewtavis I'd be interested in working on this. Would it be ok for this to be assigned to me?

[andrewtavis]

Hey @Leon-Xie123 👋 I'm in the process of working on this today :) I'd be happy to get some feedback on the plans and maybe we can find another issue for you to work on? The pages have already been migrated to just use their respective layouts, and I'm now converting all components to just use one store so that we're not making calls that are using non-existent route parameters. From there I'll separate the layout components to just be for their given pages 😊

For an issue, maybe you could work on end to end tests in #1245 or #1246? Happy to suggest a feature you could work on as well!

[Leon-Xie123]

Hey @andrewtavis no worries! I'd be happy to work on #1246 if it's still unassigned.

[andrewtavis]

By all means! Do you want to write in the issue so I can assign you? :)

[sidhartthhhhh]

Hi, I’m interested in working on this. Can I take it?

[andrewtavis]

Hey @sidhartthhhhh 👋 Appreciate your interest in the project! This issue's quite complex and I think that I need to keep at it, but should have time for it in the coming days. Do you want to check if there are other issues you'd be interested in? We just made a few more recently 😊

[andrewtavis]

CC @nicki182, this is the issue I was discussing where we need to make sure that the sidebar logic is controlled by layouts :)