activist
activist copied to clipboard
Finalize tests for page filter component
Terms
- [X] I have searched open and closed feature requests
- [X] I agree to follow activist's Code of Conduct
Description
The page filter component is being added in #1027, but we'll likely need to merge this in without the tests being finalized due to a deadline. Copying over some of the comments from @cquinn540 so we know how to improve them, and maybe @Hasteerp would have interest in finalizing all this in the coming weeks :)
The comments on test improvements can be seen at the following links:
- https://github.com/activist-org/activist/pull/1027#discussion_r1876493075
- https://github.com/activist-org/activist/pull/1027#discussion_r1876494923
- https://github.com/activist-org/activist/pull/1027#discussion_r1876499962
- There's a fourth that I'll be handling as it's just removing something
Contribution
Please let us know if you'd like to work on this, @Hasteerp!
Similarly for the testing, it would be good if this component made use of GridFilterTags instead of BtnTag, with the latter being a component we already have :)
Hello, I would like to work on this if it is still needed!
Thanks for asking to work on this, @JerryW04! Please let us know if you need any support 😊