activist icon indicating copy to clipboard operation
activist copied to clipboard

Finalize tests for page filter component

Open andrewtavis opened this issue 11 months ago • 3 comments

Terms

Description

The page filter component is being added in #1027, but we'll likely need to merge this in without the tests being finalized due to a deadline. Copying over some of the comments from @cquinn540 so we know how to improve them, and maybe @Hasteerp would have interest in finalizing all this in the coming weeks :)

The comments on test improvements can be seen at the following links:

  • https://github.com/activist-org/activist/pull/1027#discussion_r1876493075
  • https://github.com/activist-org/activist/pull/1027#discussion_r1876494923
  • https://github.com/activist-org/activist/pull/1027#discussion_r1876499962
  • There's a fourth that I'll be handling as it's just removing something

Contribution

Please let us know if you'd like to work on this, @Hasteerp!

andrewtavis avatar Dec 10 '24 03:12 andrewtavis

Similarly for the testing, it would be good if this component made use of GridFilterTags instead of BtnTag, with the latter being a component we already have :)

andrewtavis avatar Dec 10 '24 03:12 andrewtavis

Hello, I would like to work on this if it is still needed!

JerryW04 avatar Apr 22 '25 05:04 JerryW04

Thanks for asking to work on this, @JerryW04! Please let us know if you need any support 😊

andrewtavis avatar Apr 22 '25 06:04 andrewtavis