inherited_resources icon indicating copy to clipboard operation
inherited_resources copied to clipboard

Support setting parent_controller

Open jaynetics opened this issue 1 year ago • 2 comments

fixes #618

for the interface, i mirrored Devise::parent_controller=.

jaynetics avatar Mar 03 '24 19:03 jaynetics

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.92%. Comparing base (43645af) to head (f604919). Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #903   +/-   ##
=======================================
  Coverage   98.92%   98.92%           
=======================================
  Files          14       14           
  Lines         557      558    +1     
=======================================
+ Hits          551      552    +1     
  Misses          6        6           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 03 '24 19:03 codecov[bot]

rebased to bring up-to-date with master.

@tagliala could we get this one merged?

jaynetics avatar Jul 14 '24 09:07 jaynetics

I think this may be an interesting change, I may need this for a use case where I want to alias current_admin_user to current_user and add some other admin-specific actions

tagliala avatar Nov 09 '24 19:11 tagliala

My use case is the same as in the original issue: running rails in API mode.

I've been using this fork and the setting parent_controller = 'ActionController::Base' in production for 8 months now without issues.

jaynetics avatar Nov 13 '24 17:11 jaynetics