inherited_resources
inherited_resources copied to clipboard
update responders config to match default error_status & redirect_status codes for current rails version
Update responder class to the current defaults for responder gem.
Fixes #862
Codecov Report
Patch coverage: 100.00% and no project coverage change.
Comparison is base (
3e7a7e5) 98.19% compared to head (507d14a) 98.20%. Report is 11 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #863 +/- ##
=======================================
Coverage 98.19% 98.20%
=======================================
Files 14 14
Lines 555 558 +3
=======================================
+ Hits 545 548 +3
Misses 10 10
| Files Changed | Coverage Δ | |
|---|---|---|
| lib/inherited_resources/responder.rb | 100.00% <100.00%> (ø) |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Any chance to rebase and also test the see_other status?
I am not quite sure if the change is compatible with e.g. active admin etc.
Inherited Resources is no longer actively maintained by the original author and has been transferred to the ActiveAdmin organization for maintenance. New feature requests are not encouraged.
Thus I stopped working on the merge request and switched to https://github.com/heartcombo/responders.
Even though Responders has its own bugs, e.g. https://github.com/heartcombo/responders/issues/230.
Any chance to rebase, fix the rubocop offense, and add a spec for the :see_other case?
/cc @javierjulio
I will do the changes if there are any plans that they will be merged.
The priority is that any change we do continues to work with ActiveAdmin as it did before since it doesn't support Turbo currently. Thank you.
Superseded by #918.
I'm in favor of this change, even if it would need a major version bump to stay conservative.
Thanks @a-nickol, your changes have been preserved in the other PR