activeadmin-mongoid icon indicating copy to clipboard operation
activeadmin-mongoid copied to clipboard

incremented versions for gems to rails 6 ruby 2.7.0 and mongo 7

Open jesusalc opened this issue 5 years ago • 4 comments

M Gemfile M Gemfile.lock M activeadmin-mongoid.gemspec

jesusalc avatar Jan 31 '20 15:01 jesusalc

I don't understand what this PR is trying to achieve, there's to many unrelated changes in here.

deivid-rodriguez avatar Feb 04 '20 15:02 deivid-rodriguez

I don't understand what this PR is trying to achieve, there's to many unrelated changes in here.

Have tried to use activeadmin-mongoid with Ruby 2.6.5 > MongoId 7 and Rails 6 > ?

jesusalc avatar Feb 04 '20 15:02 jesusalc

I don't understand what this PR is trying to achieve, there's to many unrelated changes in here.

It looks like there's some de-linting going on, I'm definitely OK with that.

boie0025 avatar Feb 11 '20 18:02 boie0025

I did

On Wed 12. Feb 2020 at 09:45, Grzegorz Jakubiak [email protected] wrote:

@grzegorz-jakubiak commented on this pull request.

In Gemfile https://github.com/activeadmin/activeadmin-mongoid/pull/153#discussion_r378107900 :

@@ -2,9 +2,11 @@ source 'https://rubygems.org'

gemspec

-gem 'ransack-mongoid', git: 'https://github.com/activerecord-hackery/ransack-mongoid'

+# gem 'ransack-mongoid', git: 'https://github.com/activerecord-hackery/ransack-mongoid'

+gem 'ransack-mongoid', github: 'jesusalc/ransack-mongoid', branch: 'rails-6-mongoid-7-ruby-2-7-0'

@jesusalc https://github.com/jesusalc could you open a PR to ransack-mongoid? That's actually a better idea 😉

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/activeadmin/activeadmin-mongoid/pull/153?email_source=notifications&email_token=AAK7CTEE3XCMMB26Q32AHRTRCOZMFA5CNFSM4KOI47M2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCVFYQYQ#discussion_r378107900, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAK7CTDGSP5BNLPKQR3H7CDRCOZMFANCNFSM4KOI47MQ .

jesusalc avatar Feb 12 '20 09:02 jesusalc