cargo icon indicating copy to clipboard operation
cargo copied to clipboard

Please update action.yml to use Node16

Open richb-hanover opened this issue 3 years ago • 3 comments
trafficstars

Do the checklist before filing an issue:

  • [ x ] Is this related to the actions-rs Actions? If you think it's a problem related to Github Actions in general, use GitHub Community forum instead: https://github.community
  • [ x ] You've read the Contributing section about bugs reporting: https://github.com/actions-rs/.github/blob/master/CONTRIBUTING.md#reporting-bugs
  • [ Not Sure ] Is this something you can debug and fix? Send a pull request! Bug fixes and documentation fixes are welcome.

Description

In my project, I'm seeing deprecation warnings about Node12. They look like:

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: jetli/[email protected], actions-rs/cargo@v1

Could you update the action.yml file to use node16 as described in https://docs.github.com/en/actions/creating-actions/metadata-syntax-for-github-actions#runs-for-javascript-actions

Thanks!

Workflow code

See above

Action output

See above

Expected behavior

No node12 warnings

Additional context

Add any other context about the problem here.

richb-hanover avatar Nov 23 '22 01:11 richb-hanover

Is this project still maintained? It's been over a month since this was open, and there's two PRs open for it: #217 #223

If not, what's the plan? Has one been discussed anywhere?

cryptoquick avatar Dec 31 '22 20:12 cryptoquick

actions-rs is unmaintained. See discussion in https://github.com/actions-rs/toolchain/issues/216 There are comments with suggestions for alternatives.

parasyte avatar Dec 31 '22 20:12 parasyte

In case anyone's interested, I forked this Action and published a working version that uses node16: clechasseur/rs-cargo.

Since I also forked the core repository and updated it, I plan on forking some other Actions (notably clippy-check). Probably not toolchain since that seems to be covered well enough already.

clechasseur avatar Aug 06 '23 01:08 clechasseur