Actionless Loveless

Results 865 comments of Actionless Loveless

if `gi` can't be imported (or can't require version 3) - fallback to the current detection method

> The idea behind darkdetect is to depend only on packages in the standard library. https://github.com/albertosottile/darkdetect/issues/26#issuecomment-1189038270 > May I ask you what does not work with the current detection method...

`gi` **is** PyGObject

you can try copy-pasting code from there and related schemas - but that's not the way how libraries in python ecosystem meant to be used

> you expect it to be fully functional, and not having a missing dependency the current implementation have the same issue btw - if `gsettings` executable dependency won't be installed...

using gi - and catching ImportError would be the cleanest possible solution

python package doesn't have any mechanisms to control dependency on gsettings or GNOME, but have mechanism to define an optional dependency on `gi` and the main point, detecting dark color...

https://stackoverflow.com/questions/6237946/optional-dependencies-in-distutils-pip sure i'll create a PR as soon as we'll get any sort of agreement on the topic - to avoid doing the job which would be discarded

i mentioned catching ImportError - because it will help to preserve the current behavior if the optional dependency is not installed

we did some investigation previously, the root cause is what `crawlera-headless-proxy` denies any `HTTP 1.0` connection (it checking http version just from the connection string) so even just hardcoding it...