acme.sh icon indicating copy to clipboard operation
acme.sh copied to clipboard

Ensure PDNS_Url has no trailing slash ('/').

Open diffway opened this issue 11 months ago • 2 comments

The code with trailing slash

# export PDNS_Url='http://127.1.1.53:8081/'
# curl -v -H "X-API-Key: ${PDNS_API_KEY}" ${PDNS_API_URL}/api/v1/servers/localhost/zones |jq
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0*   Trying 127.1.1.53:8081...
* Connected to 127.1.1.53 (127.1.1.53) port 8081 (#0)
> GET //api/v1/servers/localhost/zones HTTP/1.1
> Host: 127.1.1.53:8081
> User-Agent: curl/7.88.1
> Accept: */*
> X-API-Key: <redacted>
>
< HTTP/1.1 404 Not Found
< Connection: close
< Content-Length: 9
< Content-Type: text/plain; charset=utf-8
<
{ [9 bytes data]
100     9  100     9    0     0    553      0 --:--:-- --:--:-- --:--:--   562
* Closing connection 0
parse error: Invalid numeric literal at line 1, column 4
#

The same code without trailing slash

# export PDNS_Url='http://127.1.1.53:8081'
# curl -v -H "X-API-Key: ${PDNS_API_KEY}" ${PDNS_API_URL}/api/v1/servers/localhost/zones |jq
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0*   Trying 127.1.1.53:8081...
* Connected to 127.1.1.53 (127.1.1.53) port 8081 (#0)
> GET /api/v1/servers/localhost/zones HTTP/1.1
> Host: 127.1.1.53:8081
> User-Agent: curl/7.88.1
> Accept: */*
> X-API-Key: <redacted>
>
< HTTP/1.1 200 OK
< Access-Control-Allow-Origin: *
< Connection: close
< Content-Length: 290
< Content-Security-Policy: default-src 'self'; style-src 'self' 'unsafe-inline'
< Content-Type: application/json
< X-Content-Type-Options: nosniff
< X-Frame-Options: deny
< X-Permitted-Cross-Domain-Policies: none
< X-Xss-Protection: 1; mode=block
<
{ [290 bytes data]
100   290  100   290    0     0  14788      0 --:--:-- --:--:-- --:--:-- 15263
* Closing connection 0
[
  {
    "account": "",
    "catalog": "",
    "dnssec": true,
    "edited_serial": 2024122408,
    "id": "<redacted>.",
    "kind": "Native",
    "last_check": 0,
    "masters": [],
    "name": "<redacted>.",
    "notified_serial": 2024122408,
    "serial": 2024122408,
    "url": "/api/v1/servers/localhost/zones/<redacted>."
  }
]
#

debug-staging-issue-error.txt debug-staging-issue-success-but-failed-to-remove.txt

diffway avatar Dec 24 '24 18:12 diffway

Welcome First thing: don't send PR to the master branch, please send to the dev branch instead. Please make sure you've read our DNS API Dev Guide and DNS-API-Test. Then reply on this message, otherwise, your code will not be reviewed or merged. Please also make sure to add/update the usage here: https://github.com/acmesh-official/acme.sh/wiki/dnsapi2 We look forward to reviewing your Pull request shortly ✨ 注意: 必须通过了 DNS-API-Test 才会被 review. 无论是修改, 还是新加的 dns api, 都必须确保通过这个测试.

github-actions[bot] avatar Dec 24 '24 18:12 github-actions[bot]

https://github.com/acmesh-official/acme.sh/wiki/DNS-API-Test

Neilpang avatar Dec 25 '24 14:12 Neilpang