acme.sh icon indicating copy to clipboard operation
acme.sh copied to clipboard

Quote echo $data in _porkbun_rest (dns_porkbun)

Open j-c-m opened this issue 1 year ago • 3 comments
trafficstars

Quote echo $data in _porkbun_rest to avoid brace expansion under ksh (OpenBSD).

j-c-m avatar Mar 07 '24 01:03 j-c-m

Welcome First thing: don't send PR to the master branch, please send to the dev branch instead. Please make sure you've read our DNS API Dev Guide and DNS-API-Test. Then reply on this message, otherwise, your code will not be reviewed or merged. We look forward to reviewing your Pull request shortly ✨ 注意: 必须通过了 DNS-API-Test 才会被 review. 无论是修改, 还是新加的 dns api, 都必须确保通过这个测试.

github-actions[bot] avatar Mar 07 '24 01:03 github-actions[bot]

First thing, tests passed.

I doubt the current code passes on OpenBSD.

On Mar 6, 2024, at 6:42 PM, github-actions[bot] @.***> wrote:

Welcome First thing: don't send PR to the master branch, please send to the dev branch instead. Please make sure you've read our DNS API Dev Guide x-msg://8/wiki/DNS-API-Dev-Guide and DNS-API-Test x-msg://8/wiki/DNS-API-Test. Then reply on this message, otherwise, your code will not be reviewed or merged. We look forward to reviewing your Pull request shortly ✨ 注意: 必须通过了 DNS-API-Test x-msg://8/wiki/DNS-API-Test 才会被 review. 无论是修改, 还是新加的 dns api, 都必须确保通过这个测试.

— Reply to this email directly, view it on GitHub https://github.com/acmesh-official/acme.sh/pull/5041#issuecomment-1982186005, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABLFTF5DR43OJCXI7RI7N2DYW7AXXAVCNFSM6AAAAABEKDVYMKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBSGE4DMMBQGU. You are receiving this because you authored the thread.

j-c-m avatar Mar 07 '24 01:03 j-c-m

https://github.com/j-c-m/acme.sh/actions/runs/8180255101

j-c-m avatar Mar 07 '24 01:03 j-c-m

Welcome First thing: don't send PR to the master branch, please send to the dev branch instead. Please make sure you've read our DNS API Dev Guide and DNS-API-Test. Then reply on this message, otherwise, your code will not be reviewed or merged. We look forward to reviewing your Pull request shortly ✨ 注意: 必须通过了 DNS-API-Test 才会被 review. 无论是修改, 还是新加的 dns api, 都必须确保通过这个测试.

OK?

j-c-m avatar Jun 13 '24 17:06 j-c-m