acl-anthology icon indicating copy to clipboard operation
acl-anthology copied to clipboard

Feedback on the new Anthology website

Open mbollmann opened this issue 6 years ago • 117 comments

This thread is intended to collect all feedback, suggestions, bug reports, etc. for the new Anthology website in the static-rewrite branch.

(Edit: live demo here at http://aclweb.org/anthology)

If you do not have a GitHub account, you're also welcome to send me feedback via e-mail ([email protected]) or Twitter (@mmbollmann)!

Known Issues

  • The search functionality now uses Google Custom Search. We're still finetuning its settings and waiting for some pages to be indexed, so please don't report any weird search behaviour just yet.
  • Author name variations (#86) are an open problem that we plan to address before the site launch.

mbollmann avatar Mar 10 '19 10:03 mbollmann

I really like it, especially the speed!

There is a display:none span containing the text "bib" in the bibtex block inside the acl-paper-link-block block. When using a text browser, this leads to the text being BibTeXbib. That span should be removed.

As a minor comment: Could you specify the hardware requirements for building the anthology a bit? How much time & memory does building take? "a considerable amount of memory" could be 8GB or 512, depending on whom you ask :-)

akoehn avatar Mar 11 '19 13:03 akoehn

It looks great! On Safari, when you click on on pdf/bib link and then click the browser's back button, the little callout ("Open PDF" or "Export BibTeX") remains on.

davidweichiang avatar Mar 11 '19 14:03 davidweichiang

awesome!!!!!!!!!

danielgildea avatar Mar 11 '19 14:03 danielgildea

I think it would look better if the header had the same width as the content. I.e., the ACL logo would move to the left and the search box to the right, in order to align with the content.

texttheater avatar Mar 11 '19 15:03 texttheater

Looks awesome! Great work! 👏

desilinguist avatar Mar 11 '19 18:03 desilinguist

What's the reason for inserting newlines in the bib field values? (for example, in booktitle here, and titles elsewhere).

mjpost avatar Mar 11 '19 19:03 mjpost

Disclaimer: This is about search, but is not about weird search behavior as such. Is Google Custom Search the long-term search solution for the new version of the Anthology? It is inherently waaaaay less functional than the existing search system on the current Anthology- for example, the current search page has really great result faceting, etc.

stevenbedrick avatar Mar 11 '19 23:03 stevenbedrick

And I just saw #165 - glad to see that something more flexible is on the roadmap/radar. In the meantime, we could also link to the DFKI "ACL Anthology Searchbench".

stevenbedrick avatar Mar 11 '19 23:03 stevenbedrick

On mobile, the magnifying glass of the search bar gets forced to the next row for me.

aryamccarthy avatar Mar 12 '19 02:03 aryamccarthy

Is the BibTeX generation handling special characters properly?

This entry has weird quotation marks in the abstract. http://aclweb.org/anthology/papers/C/C18/C18-1137.bib This one has weird things going on in the title field. http://aclweb.org/anthology/papers/K/K18/K18-3001.bib

aryamccarthy avatar Mar 12 '19 03:03 aryamccarthy

When there is just one paper in a conference, the noun after the number should be singular "paper" and not "papers". Example: Proceedings of the Pilot SENSEVAL 1 papers in http://www.aclweb.org/anthology/venues/semeval/

danielhers avatar Mar 12 '19 08:03 danielhers

Awesome work! One small issue I saw is that when I am browsing through papers in pages like this, there is no way for me to scroll back to the top instantly. The up button which is present at the beginning of the page could be floating around a corner.

rahular avatar Mar 12 '19 09:03 rahular

Is the BibTeX generation handling special characters properly?

Fixed by [6bbc5a1f4f35744f609f384e866a95bf6cc8f021]

danielgildea avatar Mar 12 '19 14:03 danielgildea

Re: https://github.com/acl-org/acl-anthology/issues/170#issuecomment-471835229, when I view in Chrome or iOS Safari, I see mojibake, but on macOS Safari, it looks fine.

Although @danielgildea's fix puts the .bib file into ASCII (as it should be), I wonder if, as a failsafe, can the server put Content-Type: application/x-bibtex; charset=utf-8 into the response header?

davidweichiang avatar Mar 12 '19 14:03 davidweichiang

What's the reason for inserting newlines in the bib field values? (for example, in booktitle here, and titles elsewhere).

anth2bib.py is just passing through newlines that are in the titles in the xml files.
I can't figure out where they come from originally. Personally, I think they make the bibtex more readable anyway.

anth2bib.py does insert newlines between author names. I think this makes it more readable, especially when names are in "Last, First" format.

danielgildea avatar Mar 12 '19 14:03 danielgildea

Is the BibTeX generation handling special characters properly?

Fixed by [6bbc5a1]

I'm seeing "CoNLL–SIGMORPHON" in macOS Safari, instead of "CoNLL–SIGMORPHON". Does the build script need to be re-run to show the fix?

aryamccarthy avatar Mar 12 '19 14:03 aryamccarthy

Does the build script need to be re-run to show the fix?

Absolutely. Fixes are not reflected on the live website until @mjpost rebuilds it and pushes it there.

mbollmann avatar Mar 12 '19 14:03 mbollmann

I agree the one-line-per-author variant is more readable and is fine with me, as long as we make sure to use spaces and not tabs (per #16).

I'll rebuild soon, by tonight at the latest. Once we have continuous integration checks built (#102) and other checks against commits to the master branch, we can have it automated.

mjpost avatar Mar 12 '19 14:03 mjpost

Thanks for all the feedback so far! I've implemented a bunch of minor layout fixes based on the comments here (with the same caveat as above: will not be live until Matt rebuilds).

Disclaimer: This is about search, but is not about weird search behavior as such. Is Google Custom Search the long-term search solution for the new version of the Anthology? It is inherently waaaaay less functional than the existing search system on the current Anthology- for example, the current search page has really great result faceting, etc.

I believe Google Custom Search is much more powerful than people give it credit for, and it offers customization options that should allow for similar result faceting and features as before. However, that requires some more work on my part, and it wasn't really possible to implement and test this earlier as, by its very nature, it requires the new site to be live and getting indexed by Google first.

I'd really like to advocate for some more patience here over the coming weeks as I'm hoping to improve this. Maintaining a custom-made search solution is a huge liability IMO, and I would really like for people to give the Google version a fair chance first.

mbollmann avatar Mar 12 '19 17:03 mbollmann

@mbollmann That's totally fair, and thank you for the reply. I certainly see the value of using an off-the-shelf/hosted search platform in general, and also of using Google Custom Search in particular as a "getting things up and running" solution. For the sake of clarity, my concerns are less about the search behavior of GCS- if anybody can build a decent text search engine, it'd be Google! My concerns are more about search UI/UX- result faceting, etc. I'm happy to give GCS more of a chance, and am looking forward to seeing what we're able to do with GCS in terms of customization. Thank you (all of you!) for your efforts on this project; I do very much like the redesign overall and am excited to see it evolve!

stevenbedrick avatar Mar 12 '19 21:03 stevenbedrick

Okay, rebuilt. I also merged in master which had some corrections.

mjpost avatar Mar 12 '19 22:03 mjpost

Unclear whether this is a parsing error or a data error: this BibTeX has no article title.

aryamccarthy avatar Mar 13 '19 02:03 aryamccarthy

Thanks! The title appears in the HTML: (http://aclweb.org/anthology/D13-1088/) and is in the XML, so I'm not sure what's going on here.

mjpost avatar Mar 13 '19 02:03 mjpost

Thanks! The title appears in the HTML: (http://aclweb.org/anthology/D13-1088/) and is in the XML, so I'm not sure what's going on here.

Pretty sure it's related somehow to the title starting with <fixed-case>. It's fixed with the refactored BibTeX generation in 7cd20c3.

mbollmann avatar Mar 13 '19 14:03 mbollmann

Ah, I was looking at the master branch. i’ll rebuild tonight.

mjpost avatar Mar 13 '19 18:03 mjpost

Done, and the problem is indeed fixed. Thanks!

mjpost avatar Mar 13 '19 21:03 mjpost

Another question of is-it-the-data-or-the-site:

SIGMORPHON has workshops listed through 2014, but one of the 2014 ones is really 2016: W16-20. On top, their 2018 workshop isn't listed on their page.

aryamccarthy avatar Mar 18 '19 19:03 aryamccarthy

Another question of is-it-the-data-or-the-site:

SIGMORPHON has workshops listed through 2014, but one of the 2014 ones is really 2016: W16-20. On top, their 2018 workshop isn't listed on their page.

It's the data: https://github.com/acl-org/acl-anthology/blob/static-rewrite/import/sigmorphon.yaml

The W16-20 one is tagged as 2014 there, and there's no entry for 2018. You can submit a PR or I can fix it sometime later.

mbollmann avatar Mar 18 '19 20:03 mbollmann

@aryamccarthy, could you submit a PR (against the static-rewrite branch)?

mjpost avatar Mar 18 '19 20:03 mjpost

Clarification question: Which will be the permanent home of the anthology, aclweb.org/anthology or aclanthology.info? Re: https://github.com/zotero/translators/issues/1702#issuecomment-475880213

nschneid avatar Mar 23 '19 16:03 nschneid