react-remarkable icon indicating copy to clipboard operation
react-remarkable copied to clipboard

Use contentWrapper prop to define the wrapper for the parsed content

Open davidowens opened this issue 8 years ago • 5 comments

Following from the issue/PR from @mightyplow Issue https://github.com/acdlite/react-remarkable/issues/24 PR https://github.com/acdlite/react-remarkable/pull/25

davidowens avatar Nov 05 '17 18:11 davidowens

Can we please get this merged?

MrSauceman avatar Nov 08 '17 17:11 MrSauceman

Do we need both container and contentWrapper properties?

jessepinho avatar Feb 28 '18 15:02 jessepinho

My change deliberately doesn’t change the markup for people who don’t opt in.

I agree that ideally we would reduce the number of wrappers, but that could potentially be a breaking change

davidowens avatar Feb 28 '18 17:02 davidowens

container=false might also be a nice (non-breaking) addition

antoniojl avatar Jul 30 '19 15:07 antoniojl

Could this please be merged into master?

misstricky avatar Oct 12 '22 16:10 misstricky