Type collisions in Axios HTTP client

[szymon-99]

trafficstars

Right now when setting

httpClientType: "axios"

Inside HTTPClient class there are some type collisions when constructing headers

I assume this file is autogenerated from here

[cardinalX]

You can use axios with version 0.21.4

"dependencies": {
    "axios": "^0.21.4",

[SLG]

You can use axios with version 0.21.4

"dependencies": {
    "axios": "^0.21.4",

While this works, of course, it's not a real solution. Is there any progress made on this?

[Liwoj]

The problem was introduced with this commit in Axios 0.23.0 by adding explicit type for default headers.

This should not be too hard to fix. I can do the PR, just need some feedback on my initial analysis (due to my limited experience and usage of/with the generator):

1. mergeRequestParams - I don't understand why this function works with Axios defaults (this.instance.defaults and this.instance.defaults.headers) in the first place. Defaults are set on the instance and will be merged into a request config by Axios itself. So these lines can be safely removed
2. request function (if (type === ContentType.FormData condition) - little bit harder to make a call as I don't understand the reason for the code and even the PR which introduced it is not clear why it manipulates the headers (almost feels like it was just useful for the contributor himself for his use case). Anyway common, put etc. keys are not allowed on headers key of the request config and must be removed

Any feedback appreciated

[furkanarabaci]

Fingers crossed for compatible fix with axios 0.24 🤞

[stavalfi]

any update?

[snufkind]

Any update on this? Would love to update axios to latest version.

[inomn]

any updates on that? thanks.

[ApacheEx]

as workaround, you can remove default headers from the api instance.

const api = new Api();

api.instance.defaults.headers.put = {};
api.instance.defaults.headers.post = {};
api.instance.defaults.headers.patch = {};


api.auth.login()

now, type: ContentType.Json is working properly. I will try to create a PR to fix this behavior (so, type prop will have more prio)

[ApacheEx]

Actually, it's already fixed in https://github.com/acacode/swagger-typescript-api/commit/94087eca8ff3d717fec054725c159e8f9f5d9cb8 (upcoming release)

[iakovalgaev]

I also have a type problem (axios 0.21.4)

this is used here

But if you just delete HeadersDefaults everything is fine.