abp
abp copied to clipboard
Blazor full stack web UI
Resolve #18289
The document: https://github.com/abpframework/abp/blob/blazor-full-stack-web-ui/docs/en/Migration-Guides/Abp-8-2-Blazor-Web-App.md
Test the CLI and new templates manually
- [x] app blazor wasm - leptonx-lite
- [x] app blazor server - leptonx-lite
- [x] app blazor server tiered - leptonx-lite
- [x] app blazor webapp - leptonx-lite
- [x] app blazor webapp tiered - leptonx-lite
- [x] app-nolayers blazor wasm - leptonx-lite
- [x] app-nolayers blazor server - leptonx-lite
- [x] module blazor - leptonx-lite
- [x] app blazor wasm - basic theme
- [x] app blazor server - basic theme
- [x] app blazor server tiered - basic theme
- [x] app blazor webapp - basic theme
- [x] app blazor webapp tiered - basic theme
- [x] app-nolayers blazor wasm - basic theme
- [x] app-nolayers blazor server - basic theme
@CodiumAI-Agent /describe
@CodiumAI-Agent /review
PR Analysis
(review updated until commit https://github.com/abpframework/abp/commit/cb37ba63a006798243c13239912993ba2f1416a3)
- ๐ฏ Main theme: Adding support for Blazor Full-Stack Web App
- ๐ PR summary: This PR adds support for Blazor Full-Stack Web App. It includes changes in multiple files, mainly in the
MyProjectNameBlazorModule.csandMyProjectNameBlazorClientModule.csfiles. The PR also includes changes in theBundlingService.csandAbpModuleHelper.csfiles. - ๐ Type of PR: Enhancement
- ๐งช Relevant tests added: No
- โฑ๏ธ Estimated effort to review [1-5]: 4, because the PR includes changes in multiple files and the changes are quite extensive. It requires a good understanding of the Blazor Full-Stack Web App to review this PR.
PR Feedback
๐ก General suggestions: The PR is well-structured and the changes are logically grouped. However, it would be beneficial to include tests to ensure the new functionality works as expected. Also, it would
โจ Usage guide:
Overview:
The review tool scans the PR code changes, and generates a PR review. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.
When commenting, to edit configurations related to the review tool (pr_reviewer section), use the following template:
/review --pr_reviewer.some_config1=... --pr_reviewer.some_config2=...
With a configuration file, use the following template:
[pr_reviewer]
some_config1=...
some_config2=...
Utilizing extra instructionsThe Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Specify the relevant sub-tool, and the relevant aspects of the PR that you want to emphasize. Examples for extra instructions:
Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable. |
How to enable\disable automation
meaning the |
About the 'Code feedback' sectionThe |
Auto-labelsThe
|
Extra sub-toolsThe |
More PR-Agent commands
|
See the review usage page for a comprehensive guide on using this tool.
Persistent review updated to latest commit https://github.com/abpframework/abp/commit/cb37ba63a006798243c13239912993ba2f1416a3
Do you know when this will be released? Is it possible to build the entire code base from your repo and get started that way? I really want to use the new template :)
Codecov Report
Attention: Patch coverage is 1.95312% with 251 lines in your changes are missing coverage. Please review.
Project coverage is 51.52%. Comparing base (
8617efd) to head (78125c6). Report is 2 commits behind head on dev.
:exclamation: Current head 78125c6 differs from pull request most recent head 2f3eba3. Consider uploading reports for the commit 2f3eba3 to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## dev #18876 +/- ##
==========================================
- Coverage 51.62% 51.52% -0.10%
==========================================
Files 3097 3096 -1
Lines 98282 98474 +192
Branches 7853 7861 +8
==========================================
+ Hits 50736 50737 +1
- Misses 45987 46178 +191
Partials 1559 1559
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
We tried to create Blazor WebApp with local CLI build:
dotnet volo.Abp.Cli.dll new BlazorWebAppTest -t app --version 8.1.0-rc.1 -csf -tv -u blazor-webapp
There are no Blazor Web App projects in the solution
Could you replace your local template zip with the current branch?
C:\Users\username\.abp\templates
abp new BookStore -t app -u blazor-webapp
The -u blazor-webapp option is used to select the Blazor Web App template.
see https://github.com/abpframework/abp/blob/blazor-full-stack-web-ui/docs/en/Migration-Guides/Abp-8-2-Blazor-Web-App.md
One thing to note: abp adds a new class, while lepton needs to use it, but lepton is using package references.