abp icon indicating copy to clipboard operation
abp copied to clipboard

Blazor full stack web UI

Open maliming opened this issue 1 year ago โ€ข 6 comments
trafficstars

Resolve #18289

The document: https://github.com/abpframework/abp/blob/blazor-full-stack-web-ui/docs/en/Migration-Guides/Abp-8-2-Blazor-Web-App.md

Test the CLI and new templates manually

  • [x] app blazor wasm - leptonx-lite
  • [x] app blazor server - leptonx-lite
  • [x] app blazor server tiered - leptonx-lite
  • [x] app blazor webapp - leptonx-lite
  • [x] app blazor webapp tiered - leptonx-lite
  • [x] app-nolayers blazor wasm - leptonx-lite
  • [x] app-nolayers blazor server - leptonx-lite
  • [x] module blazor - leptonx-lite
  • [x] app blazor wasm - basic theme
  • [x] app blazor server - basic theme
  • [x] app blazor server tiered - basic theme
  • [x] app blazor webapp - basic theme
  • [x] app blazor webapp tiered - basic theme
  • [x] app-nolayers blazor wasm - basic theme
  • [x] app-nolayers blazor server - basic theme

maliming avatar Jan 29 '24 09:01 maliming

@CodiumAI-Agent /describe

GadiZimerman avatar Jan 31 '24 12:01 GadiZimerman

@CodiumAI-Agent /review

GadiZimerman avatar Jan 31 '24 12:01 GadiZimerman

PR Analysis

(review updated until commit https://github.com/abpframework/abp/commit/cb37ba63a006798243c13239912993ba2f1416a3)

  • ๐ŸŽฏ Main theme: Adding support for Blazor Full-Stack Web App
  • ๐Ÿ“ PR summary: This PR adds support for Blazor Full-Stack Web App. It includes changes in multiple files, mainly in the MyProjectNameBlazorModule.cs and MyProjectNameBlazorClientModule.cs files. The PR also includes changes in the BundlingService.cs and AbpModuleHelper.cs files.
  • ๐Ÿ“Œ Type of PR: Enhancement
  • ๐Ÿงช Relevant tests added: No
  • โฑ๏ธ Estimated effort to review [1-5]: 4, because the PR includes changes in multiple files and the changes are quite extensive. It requires a good understanding of the Blazor Full-Stack Web App to review this PR.

PR Feedback

๐Ÿ’ก General suggestions: The PR is well-structured and the changes are logically grouped. However, it would be beneficial to include tests to ensure the new functionality works as expected. Also, it would


โœจ Usage guide:

Overview: The review tool scans the PR code changes, and generates a PR review. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR. When commenting, to edit configurations related to the review tool (pr_reviewer section), use the following template:

/review --pr_reviewer.some_config1=... --pr_reviewer.some_config2=...

With a configuration file, use the following template:

[pr_reviewer]
some_config1=...
some_config2=...
Utilizing extra instructions

The review tool can be configured with extra instructions, which can be used to guide the model to a feedback tailored to the needs of your project.

Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Specify the relevant sub-tool, and the relevant aspects of the PR that you want to emphasize.

Examples for extra instructions:

[pr_reviewer] # /review #
extra_instructions="""
In the code feedback section, emphasize the following:
- Does the code logic cover relevant edge cases?
- Is the code logic clear and easy to understand?
- Is the code logic efficient?
...
"""

Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.

How to enable\disable automation
  • When you first install PR-Agent app, the default mode for the review tool is:
pr_commands = ["/review", ...]

meaning the review tool will run automatically on every PR, with the default configuration. Edit this field to enable/disable the tool, or to change the used configurations

About the 'Code feedback' section

The review tool provides several type of feedbacks, one of them is code suggestions. If you are interested only in the code suggestions, it is recommended to use the improve feature instead, since it dedicated only to code suggestions, and usually gives better results. Use the review tool if you want to get a more comprehensive feedback, which includes code suggestions as well.

Auto-labels

The review tool can auto-generate two specific types of labels for a PR:

  • a possible security issue label, that detects possible security issues (enable_review_labels_security flag)
  • a Review effort [1-5]: x label, where x is the estimated effort to review the PR (enable_review_labels_effort flag)
Extra sub-tools

The review tool provides a collection of possible feedbacks about a PR. It is recommended to review the possible options, and choose the ones relevant for your use case. Some of the feature that are disabled by default are quite useful, and should be considered for enabling. For example: require_score_review, require_soc2_review, enable_review_labels_effort, and more.

More PR-Agent commands

To invoke the PR-Agent, add a comment using one of the following commands:

  • /review: Request a review of your Pull Request.
  • /describe: Update the PR title and description based on the contents of the PR.
  • /improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
  • /ask <QUESTION>: Ask a question about the PR.
  • /update_changelog: Update the changelog based on the PR's contents.
  • /add_docs ๐Ÿ’Ž: Generate docstring for new components introduced in the PR.
  • /generate_labels ๐Ÿ’Ž: Generate labels for the PR based on the PR's contents.
  • /analyze ๐Ÿ’Ž: Automatically analyzes the PR, and presents changes walkthrough for each component.

See the tools guide for more details. To list the possible configuration parameters, add a /config comment.

See the review usage page for a comprehensive guide on using this tool.

CodiumAI-Agent avatar Jan 31 '24 12:01 CodiumAI-Agent

Persistent review updated to latest commit https://github.com/abpframework/abp/commit/cb37ba63a006798243c13239912993ba2f1416a3

CodiumAI-Agent avatar Jan 31 '24 12:01 CodiumAI-Agent

Do you know when this will be released? Is it possible to build the entire code base from your repo and get started that way? I really want to use the new template :)

jonathan-james-dev avatar Feb 02 '24 19:02 jonathan-james-dev

Codecov Report

Attention: Patch coverage is 1.95312% with 251 lines in your changes are missing coverage. Please review.

Project coverage is 51.52%. Comparing base (8617efd) to head (78125c6). Report is 2 commits behind head on dev.

:exclamation: Current head 78125c6 differs from pull request most recent head 2f3eba3. Consider uploading reports for the commit 2f3eba3 to get more accurate results

Files Patch % Lines
.../ProjectBuilding/Building/Steps/ChangeThemeStep.cs 0.00% 148 Missing :warning:
...i/ProjectBuilding/Templates/App/AppTemplateBase.cs 0.00% 48 Missing :warning:
....Cli.Core/Volo/Abp/Cli/Bundling/BundlingService.cs 0.00% 27 Missing :warning:
...olo/Abp/Cli/Commands/ProjectCreationCommandBase.cs 0.00% 12 Missing :warning:
...ectBuilding/Templates/Module/ModuleTemplateBase.cs 0.00% 4 Missing :warning:
...Volo/Abp/AspNetCore/Uow/AbpUnitOfWorkMiddleware.cs 50.00% 2 Missing and 1 partial :warning:
...Abp.Cli.Core/Volo/Abp/Cli/Bundling/BundleConfig.cs 0.00% 2 Missing :warning:
...lo/Abp/Cli/ProjectBuilding/AbpIoSourceCodeStore.cs 0.00% 2 Missing :warning:
...uilding/Building/Steps/ChangePublicAuthPortStep.cs 0.00% 1 Missing :warning:
...ng/Building/TemplateProjectBuildPipelineBuilder.cs 0.00% 1 Missing :warning:
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #18876      +/-   ##
==========================================
- Coverage   51.62%   51.52%   -0.10%     
==========================================
  Files        3097     3096       -1     
  Lines       98282    98474     +192     
  Branches     7853     7861       +8     
==========================================
+ Hits        50736    50737       +1     
- Misses      45987    46178     +191     
  Partials     1559     1559              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 06 '24 03:02 codecov[bot]

We tried to create Blazor WebApp with local CLI build:

 dotnet volo.Abp.Cli.dll new BlazorWebAppTest -t app --version 8.1.0-rc.1 -csf -tv -u blazor-webapp

There are no Blazor Web App projects in the solution image

enisn avatar Feb 22 '24 07:02 enisn

Could you replace your local template zip with the current branch?

C:\Users\username\.abp\templates

abp new BookStore -t app -u blazor-webapp The -u blazor-webapp option is used to select the Blazor Web App template.

see https://github.com/abpframework/abp/blob/blazor-full-stack-web-ui/docs/en/Migration-Guides/Abp-8-2-Blazor-Web-App.md

One thing to note: abp adds a new class, while lepton needs to use it, but lepton is using package references.

maliming avatar Feb 22 '24 07:02 maliming

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Mar 04 '24 06:03 CLAassistant