cs2-rockthevote icon indicating copy to clipboard operation
cs2-rockthevote copied to clipboard

better nominate

Open exd02 opened this issue 1 year ago • 7 comments

  • Find the map with string containing the given name
  • Added translation (with ChatGPT) for the case of multiple maps with the same given name

*Example: Before, the !nominate swag command didn't return any maps Captura de tela 2024-02-27 002124

exd02 avatar Feb 27 '24 03:02 exd02

Thanks for the contribution, about changing the folder structure I see no value, I have a github action that generates the build automatically when I upload a new tag, so build it to bin is working fine, I also don't like having the entire folder structure from addons in the zip, just the RockTheVote folder is enough. About the nomination search it seems interesting, I will take a closer look in your implementation soon before we merge it, note that adding a new phrase to the translation means you need to add it to all languages the plugin supports not only to en and pt-br https://github.com/abnerfs/cs2-rockthevote?tab=readme-ov-file#translations so we also need to get it translated before merging

abnerfs avatar Feb 28 '24 01:02 abnerfs

  • Removed folder structure thing
  • Added translation to all languages (using ChatGPT)

Tested again: image

exd02 avatar Feb 28 '24 16:02 exd02

It's causing error when nominating a map with a similar name (I have mg_minecraft and mg_minecraft_aphixed): image

exd02 avatar Feb 28 '24 21:02 exd02

fixed

exd02 avatar Feb 28 '24 21:02 exd02

Suggestion: Make a menu for in case there are more than 2 maps that contain the same name. If this is not in your plan now, maybe we could add it later.

Oylneechan avatar Mar 28 '24 05:03 Oylneechan

Suggestion: Make a menu for in case there are more than 2 maps that contain the same name. If this is not in your plan now, maybe we could add it later.

Will work on this as well if I have time

Oz-Lin avatar Jun 02 '24 08:06 Oz-Lin

https://github.com/Oz-Lin/cs2-rockthevote/commit/1c19a3b4fe31a177eab948902286e3d8d11f0497 Listed in chat when multiple maps that contain the same name for now

Oz-Lin avatar Sep 05 '24 14:09 Oz-Lin