django-pyas2
django-pyas2 copied to clipboard
Notify via email of message transmission errors
Send an email to managers for any message transmission errors
Codecov Report
Merging #44 into master will decrease coverage by
0.44%. The diff coverage is80.00%.
@@ Coverage Diff @@
## master #44 +/- ##
==========================================
- Coverage 97.56% 97.12% -0.45%
==========================================
Files 11 11
Lines 576 591 +15
==========================================
+ Hits 562 574 +12
- Misses 14 17 +3
| Impacted Files | Coverage Δ | |
|---|---|---|
| pyas2/views.py | 97.20% <75.00%> (-0.64%) |
:arrow_down: |
| pyas2/utils.py | 93.10% <77.77%> (-6.90%) |
:arrow_down: |
| pyas2/models.py | 96.09% <100.00%> (+0.03%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 2ad2183...3fbbc9e. Read the comment docs.
@kenyonit @abhishek-ram I generally would subscribe to the idea, that an email could be sent on failed message sending. From quick look at this code, I do not see to whom this should be sent. I suppose the email as defined in the Organization? Any thoughts on this @abhishek-ram ?
Hi @abhishek-ram, could you, please, tell us if you plan merging this parts of code into your project? This is a very useful functionality that allows you to inform administrators that some messages have the ERROR status. It would be great to improve your super solution. Believe me - many people use it :)
@abhishek-ram, are you still there? Are you planning to do something with this project or is it already dead? I mean above improvements.
Should we do logger error in all these places so that devs can make use of https://docs.djangoproject.com/en/5.0/ref/logging/#django.utils.log.AdminEmailHandler to send emails?
@abhishek-ram No we shouldn't of course. I didn't know what you were writing about. You know, I'm not django expert. So many thank for your tips