HerePy icon indicating copy to clipboard operation
HerePy copied to clipboard

[FIX] Multiple parameters for route_v8

Open maciej-wichowski opened this issue 1 year ago • 1 comments
trafficstars

  1. Improve encode_parameters method, so it processes dict parameters correctly. Here API expects multi-level dict to be expressed as key[sub1]=val1&key[sub2]=val2. The method supports only one level sub-dict, which as far as I know, should be enough.
  2. Fix route_v8 - avoid, exclude and truck parameters were not fully supported.

Fixes #83

maciej-wichowski avatar Oct 15 '24 10:10 maciej-wichowski

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.99%. Comparing base (a8f1b58) to head (e1e01ff). Report is 2 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #84   +/-   ##
=======================================
  Coverage   92.98%   92.99%           
=======================================
  Files          26       26           
  Lines        1754     1755    +1     
=======================================
+ Hits         1631     1632    +1     
  Misses        123      123           
Flag Coverage Δ
unittests 92.99% <100.00%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Oct 15 '24 10:10 codecov-commenter