transpiler icon indicating copy to clipboard operation
transpiler copied to clipboard

Use node:sqlite instead of sql.js

Open MarkTiedemann opened this issue 1 year ago • 1 comments

Since Node 22, there's a built-in node:sqlite module: https://nodejs.org/docs/latest-v22.x/api/sqlite.html

For now, it's experimental and has to be enabled using --experimental-sqlite.

Long term, it might be a good idea to use this module instead of sql.js to remove the dependency (as well as the dependency on WASM).

Not sure whether you are interested in a PR for this yet. If so, I forked and prepared a branch with green CI: https://github.com/abaplint/transpiler/compare/main...MarkTiedemann:abaplint-transpiler:sqlite

MarkTiedemann avatar Aug 23 '24 19:08 MarkTiedemann

Hi, Thanks, feel free to publish a package

gonna update it to the built-in sometime, but not while its behind experimental flag, what is there now works. I'm not gonna force everyone to change their setups to have the experimental flag, which is probably gonna be removed.

larshp avatar Aug 24 '24 04:08 larshp

unflagged in v22.13.0 released in January 2025

latest vscode running 22.17.0

larshp avatar Aug 23 '25 07:08 larshp