transpiler icon indicating copy to clipboard operation
transpiler copied to clipboard

Cannot add only one value for `input_folder` in `abap_transpile.json`

Open iliyan-velichkov opened this issue 1 year ago • 3 comments

The following single value is not supported

{
  "input_folder": "{src/abap}",
  "input_filter": [],
  "output_folder": "dist/abap",
  "libs": [
    {
      "url": "https://github.com/open-abap/open-abap-core"
    },
    {
      "files": "/**/*.*",
      "folder": "/../../../../../root/registry/public/kronos/src/abap"
    }
  ],
  "write_unit_tests": true,
  "write_source_map": true,
  "options": {
    "ignoreSyntaxCheck": false,
    "addFilenames": true,
    "addCommonJS": true,
    "unknownTypes": "runtimeError",
    "skip": []
  }
}
2024-06-24 15:33:32.962 [INFO ] [Thread-1469] [background] o.e.d.c.i.w.service.ActionsService - > rm -rf output && abap_transpile abap_transpile.json
2024-06-24 15:33:32.962 [INFO ] [Thread-1469] [background] o.e.d.c.i.w.service.ActionsService - 
2024-06-24 15:33:33.218 [INFO ] [Thread-1469] [background] o.e.d.c.i.w.service.ActionsService - Transpiler CLI
2024-06-24 15:33:33.219 [INFO ] [Thread-1469] [background] o.e.d.c.i.w.service.ActionsService - Using config: abap_transpile.json
2024-06-24 15:33:33.219 [INFO ] [Thread-1469] [background] o.e.d.c.i.w.service.ActionsService - Clone: https://github.com/open-abap/open-abap-core
2024-06-24 15:33:34.698 [INFO ] [Thread-1469] [background] o.e.d.c.i.w.service.ActionsService - 	515 files added from lib
2024-06-24 15:33:34.954 [INFO ] [Thread-1469] [background] o.e.d.c.i.w.service.ActionsService - From folder: /../../../../../root/registry/public/kronos/src/abap
2024-06-24 15:33:34.955 [INFO ] [Thread-1469] [background] o.e.d.c.i.w.service.ActionsService - 	1 files added from lib
2024-06-24 15:33:34.957 [INFO ] [Thread-1469] [background] o.e.d.c.i.w.service.ActionsService - 0 files added from source
2024-06-24 15:33:34.957 [INFO ] [Thread-1469] [background] o.e.d.c.i.w.service.ActionsService - 0 files skipped in source
2024-06-24 15:33:34.957 [INFO ] [Thread-1469] [background] o.e.d.c.i.w.service.ActionsService - 

If I change input_folder to {src/abap,test/src} it works

2024-06-24 15:35:30.661 [INFO ] [Thread-1601] [background] o.e.d.c.i.w.service.ActionsService - > rm -rf output && abap_transpile abap_transpile.json
2024-06-24 15:35:30.661 [INFO ] [Thread-1601] [background] o.e.d.c.i.w.service.ActionsService - 
2024-06-24 15:35:31.112 [INFO ] [Thread-1601] [background] o.e.d.c.i.w.service.ActionsService - Transpiler CLI
2024-06-24 15:35:31.113 [INFO ] [Thread-1601] [background] o.e.d.c.i.w.service.ActionsService - Using config: abap_transpile.json
2024-06-24 15:35:31.113 [INFO ] [Thread-1601] [background] o.e.d.c.i.w.service.ActionsService - Clone: https://github.com/open-abap/open-abap-core
2024-06-24 15:35:32.428 [INFO ] [Thread-1601] [background] o.e.d.c.i.w.service.ActionsService - 	515 files added from lib
2024-06-24 15:35:32.474 [INFO ] [Thread-1601] [background] o.e.d.c.i.w.service.ActionsService - From folder: /../../../../../root/registry/public/kronos/src/abap
2024-06-24 15:35:32.476 [INFO ] [Thread-1601] [background] o.e.d.c.i.w.service.ActionsService - 	1 files added from lib
2024-06-24 15:35:32.477 [INFO ] [Thread-1601] [background] o.e.d.c.i.w.service.ActionsService - 1 files added from source
2024-06-24 15:35:32.477 [INFO ] [Thread-1601] [background] o.e.d.c.i.w.service.ActionsService - 0 files skipped in source

Of course I can use just src/abap but I would expect that {src/abap} will work as well. Also, in my opinion will be better if you use array for specifying more than one value, or use array always.

{
  "input_folder": ["src/abap", "test/src"]
}

iliyan-velichkov avatar Jun 24 '24 12:06 iliyan-velichkov

good idea 👍

larshp avatar Jun 27 '24 12:06 larshp

#1472

larshp avatar Sep 26 '24 17:09 larshp

@iliyan-velichkov try again, latest version

larshp avatar Sep 28 '24 08:09 larshp