abapGit
abapGit copied to clipboard
abapGit
SAPGUI 7.70 - Issues with chromium-based browser control (WebView/Edge)
Collection of issues as discussed in the slack channel and PR #4840 These errors only occur with SAPGUI 7.70 for windows PL2 and chromium based browser control. None of the occur with IE control or with previous patch level.
-
[x] "Unknown action: SELECT" -> #4840
-
[x] Back navigation doesn't work -> https://github.com/abapGit/abapGit/pull/4840#issuecomment-860035017
-
[ ] Patch doesn't work - add file and click 'Patch'
-
[x] Diff doesn't work -> Shortdump
Filename is UPPERCASE
-
[ ] Stage page: 'Change by (me)' doesn't work
-
[x] Bad performance. Every navigation step/action takes ~2 seconds
I just test the PL03 and it seems that all the problems (or at least almost) are fixed.
@christianguenter2 can you test it with the last PL03?
Thanks for the info. I just did a quick test and some issues are fixed (marked above). Few still exist. @jrodriguez-rc Is your OSS call still open? If yes can forward that to SAP? Many thanks for your effort.
The issue reported to SAP was closed by inactivity, I was waiting for this patch to test and report feedback.
https://blogs.sap.com/2021/01/27/sap-gui-for-windows-7.70-new-features-lifecycle-information/comment-page-1/#comment-584714
Thanks for the hint. Just tested PL3 Hotfix 1. Issues still exist.
I tested the staging problem with PL4 and it still exists, though for me it happens on any filter action, not just the "Changed by (me)". Haven't tested the other open topics.
Small update: The staging issue and filtering issue still exists with SAP GUI 7.70 PL5.
It looks to me like the remaining issues are related to the use of SAPEVENT: within the abapGit JavaScript (to submit a form). The Edge control does not support this (yet). This is documented in SAP Note 2901278:
"Custom URI Scheme support: Webview2 currently does not have Custom URI Scheme support (URLs starts with SAPHTML, SAPHTMLP, SAPEVENT, SAPR3 etc). Microsoft is working on this feature. As per recent communication from Microsoft the APIs will be available from Edge browser version 103(Microsoft initially told 102 version but now it is postponed by them). For Edge browser version release dates please refer https://docs.microsoft.com/en-us/deployedge/microsoft-edge-release-schedule. After this SAP requires at least two to three months time to consume these APIs and release to customers."
Revisiting the issue end of August 2022 seems feasible.
SAP Note 2901278 was updated regarding SAPEVENT and new note 3228419 was created.
Though not yet released.
I've just updated Edge to:
Version 109.0.1518.55 (Official build) (64-bit)
and I can confirm that this issue still does exist. Will watch SAP Note 3228419 now.
Good news I guess 3331099 - SAP GUI for Windows Edge HTML control: Custom URI scheme support is now available
Hm, note says this supposed to be fixed with PL3?
Can't remember having problems with sole diff.
SAP GUI 800 PL03 seems to break actions in abapgit:
https://github.com/abapGit/abapGit/assets/6908247/5d9c78dc-75ff-4b14-a509-e6aa65899c9f
Probably related to notes 3337501, 3331099, 3335007
I think I see the issue: The actions are in upper case but AG expects them lower case. @WegnerDan can you test the following fix, please?
https://github.com/abapGit/abapGit/blob/main/src/ui/core/zcl_abapgit_gui_event.clas.abap#L47
zif_abapgit_gui_event~mv_action = to_lower( iv_action ).
What is the solution for this issue? i found only note 331099 here. his note is not relevant on my system. Still have SAPGUI 770 patchlevel 5 is it fixed in https://github.com/abapGit/abapGit/pull/6336 ? and also gui patch needed? Using the last ABAPgit Standalone and SAPGUI 770 patchlevel 5 i still have this issue
#6339 is still open and tracking the overall status. We will need to adjust AG to handle the uppercase SAPEVENT and wait for the next SAP GUI patch that fixes encoding of URL parameters including slashes.